Add log_delivery_configuration

[nitrocode]

what

• Add log_delivery_configuration

why

• New functionality

references

• Closes Support log delivery configuration #162
• Closes v0.43.0 should require aws >=4.0, because it uses root level "replicas_per_node_group" #167
• Upstream log_delivery_configuration argument for aws_elasticache_replication_group
• Double checked and inspired by umotif-public's module

Test

Test this out in your infrastructure

module "cloudwatch_logs" {
  source  = "cloudposse/cloudwatch-logs/aws"
  # Cloud Posse recommends pinning every module to a specific version
  # version = "x.x.x"

  context = module.this.context
}

module "redis" {
  # source = "cloudposse/elasticache-redis/aws"
  # Cloud Posse recommends pinning every module to a specific version
  # version = "x.x.x"

  source = "git::https://github.com/cloudposse/terraform-aws-elasticache-redis.git?ref=log_delivery"

  log_delivery_configuration = [
    {
      destination      = module.cloudwatch_logs.log_group_name
      destination_type = "cloudwatch-logs"
      log_format       = "json"
      log_type         = "engine-log"
    }
  ]

  context = module.this.context
}

[nitrocode]

/test all

[nitrocode]

/test all

[bridgecrew]

⚠️   Due to fd9d3a9 - Move dynamics to correct block - 3 new errors were added

Change details

Error ID	Change	Path	Resource
BC_AWS_GENERAL_9	Added	/main.tf	aws_elasticache_replication_group.default
BC_AWS_GENERAL_111	Added	/main.tf	aws_elasticache_replication_group.default
BC_AWS_GENERAL_10	Added	/main.tf	aws_elasticache_replication_group.default

[nitrocode]

/test all

[nitrocode]

/test all

[nitrocode]

/test all

[aknysh]

should we convert it to a map (in locals) to prevent updating the whole list if any item changes?

[nitrocode]

Only two items can be used here, one for each log_type. We could turn it into a map but i think it would be overkill.

[aknysh]

are any of these required, or they are all optional?
(if required, we should not provide the default null value)

[nitrocode]

The docs do not say. I haven't looked at the golang code and the test sets every key. I figured I'd err on the side of caution and default to null in case one was optional.

[aknysh]

please see comments

[aknysh]

/test all