-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log_delivery_configuration
#168
Changes from all commits
567702d
08f0798
f9681ba
49de8d4
50608bf
88038f2
748f4b1
fd9d3a9
b52be7b
6e09383
058323a
c4dcf00
aa41afb
ad14e9c
39c7f95
b47a50e
73c83fa
15f1e82
8d58dde
4624cb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
terraform { | ||
required_version = ">= 0.13.0" | ||
required_version = ">= 0.14.0" | ||
|
||
required_providers { | ||
aws = { | ||
source = "hashicorp/aws" | ||
version = ">= 2.0" | ||
} | ||
null = { | ||
source = "hashicorp/null" | ||
version = ">= 2.0" | ||
version = ">= 4.18" | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,7 +102,6 @@ resource "aws_elasticache_parameter_group" "default" { | |
} | ||
} | ||
|
||
|
||
tags = module.this.tags | ||
|
||
# Ignore changes to the description since it will try to recreate the resource | ||
|
@@ -144,6 +143,17 @@ resource "aws_elasticache_replication_group" "default" { | |
final_snapshot_identifier = var.final_snapshot_identifier | ||
apply_immediately = var.apply_immediately | ||
|
||
dynamic "log_delivery_configuration" { | ||
for_each = var.log_delivery_configuration | ||
|
||
content { | ||
destination = lookup(log_delivery_configuration.value, "destination", null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are any of these required, or they are all optional? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The docs do not say. I haven't looked at the golang code and the test sets every key. I figured I'd err on the side of caution and default to null in case one was optional. |
||
destination_type = lookup(log_delivery_configuration.value, "destination_type", null) | ||
log_format = lookup(log_delivery_configuration.value, "log_format", null) | ||
log_type = lookup(log_delivery_configuration.value, "log_type", null) | ||
} | ||
} | ||
|
||
tags = module.this.tags | ||
|
||
num_node_groups = var.cluster_mode_enabled ? var.cluster_mode_num_node_groups : null | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ terraform { | |
required_providers { | ||
aws = { | ||
source = "hashicorp/aws" | ||
version = ">= 3.26" | ||
version = ">= 4.18" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we convert it to a map (in locals) to prevent updating the whole list if any item changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two items can be used here, one for each
log_type
. We could turn it into a map but i think it would be overkill.