Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making tags for roles optional #43

Merged
merged 5 commits into from
Apr 1, 2022
Merged

Making tags for roles optional #43

merged 5 commits into from
Apr 1, 2022

Conversation

jamengual
Copy link
Contributor

what

  • Make role tags optional

why

  • Restrictive policy boundaries do not allow tag roles in highly secure environments.

@jamengual jamengual requested review from a team as code owners March 31, 2022 00:09
@jamengual
Copy link
Contributor Author

/test all

1 similar comment
@aknysh
Copy link
Member

aknysh commented Mar 31, 2022

/test all

@aknysh
Copy link
Member

aknysh commented Apr 1, 2022

@jamengual thank you for the PR, please review these errors

Error: Unsupported attribute

  on .terraform/modules/bucket/main.tf line [34](https://github.com/cloudposse/actions/runs/5777893853?check_suite_focus=true#step:9:34), in resource "aws_s3_bucket" "default":
  34:       for_each = var.enable_glacier_transition ? [1] : []

This object does not have an attribute named "enable_glacier_transition".


Error: Unsupported attribute

  on .terraform/modules/bucket/main.tf line 43, in resource "aws_s3_bucket" "default":
  43:       for_each = var.enable_standard_ia_transition ? [1] : []

aknysh
aknysh previously requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@jamengual
Copy link
Contributor Author

But But But I never changed any of those attributes....

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@mergify mergify bot dismissed aknysh’s stale review April 1, 2022 18:42

This Pull Request has been updated, so we're dismissing all reviews.

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

@aknysh fixed

Gowiem
Gowiem approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're good with capping the example AWS provider version... Doesn't actually affect this module so I am good with it at least

LGTM 👍

@Gowiem Gowiem merged commit a17b317 into master Apr 1, 2022
@Gowiem Gowiem deleted the make_role_tags_optional branch April 1, 2022 23:08
@jamengual jamengual mentioned this pull request Apr 10, 2022
Merged
This was referenced Apr 11, 2022
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@aknysh aknysh aknysh left review comments

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamengual @aknysh @Gowiem @cloudpossebot