Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling all tags in all iam resources #44

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Disabling all tags in all iam resources #44

merged 2 commits into from
Apr 11, 2022

Conversation

jamengual
Copy link
Contributor

what

  • In Making tags for roles optional #43 I added the option to disable role tags but in environments where roles are created under very strict controls, the policy tags for the roles sometimes can't be tagged. This change disable tags for all IAM related resources.

why

  • to disable tags for role-related things. Use one variable instead of two.

references

@jamengual jamengual requested review from a team as code owners April 10, 2022 21:43
@jamengual
Copy link
Contributor Author

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Apr 11, 2022
@jamengual jamengual merged commit d86dbaf into master Apr 11, 2022
@jamengual jamengual deleted the disable_all_tags branch April 11, 2022 19:02
@jamengual jamengual mentioned this pull request Apr 11, 2022
Merged
This was referenced Apr 13, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamengual @nitrocode @cloudpossebot