Fails if invalid custom types are specified #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
force-pushed
the
custom_type_validation
branch
3 times, most recently
from
3140d0c
to
d73d3ce
Compare
shuheiktgw
force-pushed
the
custom_type_validation
branch
from
d73d3ce
to
3790e3b
Compare
shuheiktgw
commented
Dec 18, 2021
| @@ -26,5 +26,5 @@ tables: | |||
| - name: "FullTypes" | |||
| columns: | |||
| FTInt: "int32" | |||
| FTInitNull: "uint64" | |||
| FTIntNull: "uint64" | |||
There was a problem hiding this comment.
I've fixed this typo then it raises an error since yo tries to convert spanner.NullInt64 into uint64. What should I do to resolve the problem? 🤔
There was a problem hiding this comment.
hmm, it seems broken in this type conversion. Please just remove this line from the yaml for now.
kazegusuri
reviewed
Dec 20, 2021
v2/loader/loader.go
Outdated
|
|
||
| // validate custom type columns | ||
| if columnTypes != nil { | ||
| columnSet := map[string]bool{} |
There was a problem hiding this comment.
super nit: good to use map[string]struct{}{} when the value is meaningless, then substitute struct{}{} instead of true
|
@kazegusuri Updated it! Would you review the PR again? 🙏 |
kazegusuri
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the contribution guidelines and the CLA carefully before
submitting your pull request.
https://cla.developers.google.com/
Currently, the
yocommand succeeds even if non-existing custom type tables or columns are specified. This behavior makes it hard for users to notice misconfiguration in their custom types. It would be great ifyowould validate their existence so I implemented the logic. Thank you for your review!