Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails if invalid custom types are specified #84

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Fails if invalid custom types are specified #84

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5ddeea
Fails if invalid custom types are specified
shuheiktgw Dec 18, 2021
3790e3b
Rename FTInitNull -> FTIntNull
shuheiktgw Dec 18, 2021
49c4daa
Remove the FTIntNull column from tests
shuheiktgw Dec 21, 2021
3d86460
Use map[string]struct{}{} instead for HashSet
shuheiktgw Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/testdata/custom_column_types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ tables:
- name: "FullTypes"
columns:
FTInt: "int32"
FTInitNull: "uint64"
FTIntNull: "uint64"
Copy link
Collaborator Author

@shuheiktgw shuheiktgw Dec 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this typo then it raises an error since yo tries to convert spanner.NullInt64 into uint64. What should I do to resolve the problem? 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it seems broken in this type conversion. Please just remove this line from the yaml for now.

FTFloat: "float32"
11 changes: 7 additions & 4 deletions test/testmodels/customtypes/fulltype.yo.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.