Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization in AwsVpcConfiguration #1788

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Fix capitalization in AwsVpcConfiguration #1788

merged 1 commit into from
Sep 22, 2020

Conversation

akarve
Copy link
Contributor

@akarve akarve commented Sep 21, 2020

Switch to the AWS documented capitalization to avoid the following error (and related):

E3002 Invalid Property Resources/BulkScannerService/Properties/NetworkConfiguration/AwsvpcConfiguration

which appears in cfn-lint==0.36.1

I attempted to run the unit tests but in vera case bottomed out with

======================================================================
ERROR: test_CustomResource (tests.test_examples.TestExamples)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/karve/code/troposphere/.eggs/awacs-0.9.8-py3.6.egg/tests/test_examples.py", line 21, in test_file
    exec(code)
  File "examples/CustomResource.py", line 5, in <module>
    class CustomPlacementGroup(AWSCustomObject):
  File "examples/CustomResource.py", line 9, in CustomPlacementGroup
    'ServiceToken': (basestring, True),
NameError: name 'basestring' is not defined

----------------------------------------------------------------------
Ran 107 tests in 0.302s

and didn't see documentation on overcoming the same.

@markpeek markpeek merged commit 1ca9e8c into cloudtools:master Sep 22, 2020
@markpeek
Copy link
Member

Thanks!

@akarve
Copy link
Contributor Author

akarve commented Sep 22, 2020

Sure thing, just note that the backend issue is still resolving aws-cloudformation/cfn-lint#1706

@michael-k
Copy link
Contributor

I attempted to run the unit tests but in vera case bottomed out with

You have to invoke them with python setup.py test or run 2to3 manually on the codebase.

use_2to3=True,

@PatMyron
Copy link
Contributor

PatMyron commented Oct 2, 2020

This property was accidentally uppercased during the migration of AWS::ECS::Service to the CloudFormation Registry in Resource Specification 18.4.0 and reverted in 18.6.0. It should probably be kept lowercase

michael-k added a commit to michael-k/troposphere that referenced this pull request Oct 4, 2020
See comment by Pat Myron from AWS:

    This property was accidentally uppercased during the migration of
    `AWS::ECS::Service` to the CloudFormation Registry in Resource
    Specification 18.4.0 and reverted in 18.6.0. It should probably be
    kept lowercase

cloudtools#1788 (comment)

This reverts commit 1ca9e8c.
michael-k added a commit to michael-k/troposphere that referenced this pull request Oct 4, 2020
See comment by Pat Myron from AWS:

    This property was accidentally uppercased during the migration of
    `AWS::ECS::Service` to the CloudFormation Registry in Resource
    Specification 18.4.0 and reverted in 18.6.0. It should probably be
    kept lowercase

cloudtools#1788 (comment)

This reverts commit 1ca9e8c.
markpeek pushed a commit that referenced this pull request Oct 4, 2020
See comment by Pat Myron from AWS:

    This property was accidentally uppercased during the migration of
    `AWS::ECS::Service` to the CloudFormation Registry in Resource
    Specification 18.4.0 and reverted in 18.6.0. It should probably be
    kept lowercase

#1788 (comment)

This reverts commit 1ca9e8c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants