Revert "Fix capitalization in AwsVpcConfiguration (cloudtools#1788)"

See comment by Pat Myron from AWS: This property was accidentally uppercased during the migration of `AWS::ECS::Service` to the CloudFormation Registry in Resource Specification 18.4.0 and reverted in 18.6.0. It should probably be kept lowercase cloudtools#1788 (comment) This reverts commit 1ca9e8c.
michael-k · Oct 4, 2020 · 04de256 · 04de256
1 parent b217e5b
commit 04de256
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/examples/ECSFargate.py b/examples/ECSFargate.py
@@ -2,7 +2,7 @@
 from troposphere.ecs import (
     Cluster, Service, TaskDefinition,
     ContainerDefinition, NetworkConfiguration,
-    AwsVpcConfiguration, PortMapping
+    AwsvpcConfiguration, PortMapping
 )
 
 t = Template()
@@ -40,7 +40,7 @@
     TaskDefinition=Ref(task_definition),
     LaunchType='FARGATE',
     NetworkConfiguration=NetworkConfiguration(
-        AwsVpcConfiguration=AwsVpcConfiguration(
+        AwsvpcConfiguration=AwsvpcConfiguration(
             Subnets=[Ref('Subnet')]
         )
     )

diff --git a/tests/examples_output/ECSFargate.template b/tests/examples_output/ECSFargate.template
@@ -18,7 +18,7 @@
                 "DesiredCount": 1,
                 "LaunchType": "FARGATE",
                 "NetworkConfiguration": {
-                    "AwsVpcConfiguration": {
+                    "AwsvpcConfiguration": {
                         "Subnets": [
                             {
                                 "Ref": "Subnet"

diff --git a/tests/test_ecs.py b/tests/test_ecs.py
@@ -88,7 +88,7 @@ def test_fargate_launch_type(self):
             ],
             LaunchType='FARGATE',
             NetworkConfiguration=ecs.NetworkConfiguration(
-                AwsVpcConfiguration=ecs.AwsVpcConfiguration(
+                AwsvpcConfiguration=ecs.AwsvpcConfiguration(
                     AssignPublicIp='DISABLED',
                     SecurityGroups=['sg-1234'],
                     Subnets=['subnet-1234']

diff --git a/troposphere/ecs.py b/troposphere/ecs.py
@@ -147,7 +147,7 @@ class PlacementStrategy(AWSProperty):
     }
 
 
-class AwsVpcConfiguration(AWSProperty):
+class AwsvpcConfiguration(AWSProperty):
     props = {
         'AssignPublicIp': (basestring, False),
         'SecurityGroups': (list, False),
@@ -157,7 +157,7 @@ class AwsVpcConfiguration(AWSProperty):
 
 class NetworkConfiguration(AWSProperty):
     props = {
-        'AwsVpcConfiguration': (AwsVpcConfiguration, False),
+        'AwsvpcConfiguration': (AwsvpcConfiguration, False),
     }