Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mod for govulncheck #1051

Closed
wants to merge 2 commits into from

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Jan 18, 2024

What type of PR is this?

update the mod for govulncheck

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@haoxins haoxins requested review from a team as code owners January 18, 2024 08:07
@haoxins
Copy link
Contributor Author

haoxins commented Jan 18, 2024

BTW, can we open the dependabot for this project?

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d25abe) 82.49% compared to head (4066a88) 82.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1051      +/-   ##
===========================================
+ Coverage    82.49%   82.55%   +0.05%     
===========================================
  Files           98       98              
  Lines        10025    10025              
===========================================
+ Hits          8270     8276       +6     
+ Misses        1258     1252       -6     
  Partials       497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jin-gou
Copy link
Member

BTW, can we open the dependabot for this project?

Add a PR description so we know what it does.

@haoxins
Copy link
Contributor Author

haoxins commented Jan 18, 2024

BTW, can we open the dependabot for this project?

Add a PR description so we know what it does.

I mean add a file named dependabot.yml in the .github dir, this content will look like

version: 2
updates:
- package-ecosystem: gomod
  directory: ./
  schedule:
    interval: weekly
    day: friday

this is the GitHub workflow's function

see https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/

@a631807682
Copy link
Member

BTW, can we open the dependabot for this project?

refer to hertz-contrib/registry#36

@li-jin-gou
Copy link
Member

li-jin-gou commented Jan 19, 2024

BTW, can we open the dependabot for this project?

refer to hertz-contrib/registry#36

@a631807682 @haoxins 不自动升级依赖的原因是

  1. 升级代码库可能存在 bk,为了稳定性能不动的依赖升级尽量都不动。
  2. 有的库依赖 Go 的高版本特性,用户的 Go 版本分布比较散,而且有些用户还卡了 Go 的版本。

英文可能翻译不准确所以直接用中文了。

@haoxins
Copy link
Contributor Author

haoxins commented Jan 19, 2024

okk.
那我先 closed 这个~

@haoxins haoxins closed this Jan 19, 2024
@haoxins haoxins deleted the govulncheck branch January 19, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants