-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add dependabot for deps version update #36
Conversation
我昨天看了下,像 etcd 和 redis 新版本有不兼容升级,这是是不是应该谨慎升级呀 |
只是自动提 |
好的,那我没问题了 |
所有三方依赖的更新都需要严格的review和内部稳定性测试,目前应该没有足够的人力能够review & 保证这个更新不会引入潜在的问题。简单来说一个是ROI不高,二个是风险难以把控。 这个依赖更新我们按需搞吧,目前的策略是人工提交,来合入必要的更新;这一点可能相对其他的开源项目来说会相对保守一些,字节线上是有大量服务依赖 hertz 的,相较于其他激进的开源项目,在稳定性的考量这一个点上,我们会趋向于相对保守一些。 根据 Golang 依赖传递策略,框架指定的 SDK 版本其实并不限制用户自己主动的升级行为。如果有用户愿意去升级某些 SDK,可以自行去做这个事情,同时也能够对 SDK 的版本变化拥有自主的控制和感知。 |
update: 以上是针对 Hertz 主库的逻辑,其他contrib没有这么严格,我重新打开了。 |
@a631807682 Seems that the frequency configuration doesn't seem to be working? Check here. The noise is too much now... |
The frequency is effective, first checked on the day of the merge, and then on the 1st of each month thereafter. |
The following makes noise:
@welkeyever Since Scene 1 makes the most noise, and there's nothing we can do about it, I recommend disabling it. |
@a631807682 Agree, maybe re-enable it when we find a better way to use it. |
…)" This reverts commit fe227d1.
I saw a discussion about dependabot in cloudwego from other contributors, so I'll update with the latest news. dependabot/dependabot-core#1190 (comment) |
What type of PR is this?
use dependabot to update project deps version.
refer to https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
What this PR does / why we need it (English/Chinese):
en: Avoid the hassle of manually updating dependencies
zh: 避免手动更新依赖
Which issue(s) this PR fixes: