Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AccessLogHandler part of public API #174

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

clue
Copy link
Owner

@clue clue commented Jul 22, 2022

This changeset makes the existing AccessLogHandler part of the public API. It can now be given explicitly to the App like this:

<?php

require __DIR__ . '/../vendor/autoload.php';

$app = new FrameworkX\App(
    new FrameworkX\AccessLogHandler(),
    new FrameworkX\ErrorHandler()
);

// Register routes here, see routing…

$app->run();

This is a starting point to add more options to control access logging in follow-up PRs as discussed in #169.

Builds on top of #173 and #45, #47, #48, #49, #50 and others

@clue clue added the new feature New feature or request label Jul 22, 2022
@clue clue requested a review from SimonFrings July 22, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants