Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show empty response body size in access log when response body MUST be empty #50

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Show empty response body size in access log when response body MUST be empty #50

merged 1 commit into from
Nov 5, 2021

Conversation

clue
Copy link
Owner

@clue clue commented Nov 4, 2021

This changeset ensures we always log an empty response body size in the access log when the response body MUST be empty, such as for HEAD requests, 204 No Content and 304 Not Modified.

2021-01-29 12:22:01.717 - "GET /users HTTP/1.1" 304 0 0.000

Builds on top of #45, #46, #47, #48, #49
Refs reactphp/http#429

@clue clue added the new feature New feature or request label Nov 4, 2021
@clue clue requested a review from SimonFrings November 4, 2021 20:37
@SimonFrings SimonFrings merged commit 192296a into clue:main Nov 5, 2021
@SimonFrings SimonFrings deleted the log-no-body branch November 5, 2021 08:06
This was referenced Nov 5, 2021
Merged
Merged
@clue clue mentioned this pull request Jul 22, 2022
Merged
@SimonFrings SimonFrings added this to the v0.4.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @SimonFrings