Reformat all python script with Black

[iarspider]

No description provided.

[cmsbuild]

A new Pull Request was created by @iarspider for branch master.

@iarspider, @cmsbuild, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

test parameters:

• full_cmssw = true

[smuzaffar]

please test with cms-sw/cmsdist#8791

[smuzaffar]

please test for CMSSW_8_0_X

[iarspider]

Notice:

1. I propose to make the resulting commit authored by cms-bot.

2. There is also a way to make github (automatically) and git client (semi-automatically, unfortunately) to ignore the formatting commit - see, e.g., this article.

3. I also propose to rename all python files to end with .py, and make original names symlinks (or dummy shell scripts running python3 <myname>.py). This will help to avoid explicitly listing all additional python scripts that need to be checked at push.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1879c/35524/summary.html
COMMIT: d64ce05
CMSSW: CMSSW_8_0_X_2023-10-29-0000/slc6_amd64_gcc530
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2099/35524/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 25 errors in the following unit tests:

---> test testNamedReference had ERRORS
---> test testORA_9 had ERRORS
---> test testNestedArrays had ERRORS
and more ...

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 1044635
• DQMHistoTests: Total failures: 847
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1043680
• DQMHistoTests: Total skipped: 108
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
• Checked 62 log files, 40 edm output root files, 15 DQM output files

[iarspider]

I found 25 errors in the following unit tests:

Also present in IBs

[smuzaffar]

thanks @iarspider , changes looks good. Can we run black during the github actions?

1. I propose to make the resulting commit authored by cms-bot.

there is no need for cms-bot/build to be the author.

2. There is also a way to make github (automatically) and git client (semi-automatically, unfortunately) to ignore the formatting commit - see, e.g., [this article](https://moxio.com/blog/ignoring-bulk-change-commits-with-git-blame/).

If I am reading the above artica correctly then looks like git client (version >=2.32) can ignore a commits for blame but github and gitlab do not support it yet.

If you want then please go ahead and add .git-blame-ignore-revs file too

3. I also propose to rename all python files to end with `.py`, and make original names symlinks (or dummy shell scripts running `python3 <myname>.py`). This will help to avoid explicitly listing all additional python scripts that need to be checked at push.

sounds good. May be you can do this once this PR is merged.

[iarspider]

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

[iarspider]

Let's merge #2096 first, I will then rebase this one on top so that I don't have to reformat files touched in that one again.

[cmsbuild]

Pull request #2099 was updated.

[cmsbuild]

Pull request #2099 was updated.

[cmsbuild]

Pull request #2099 was updated.

[cmsbuild]

Pull request #2099 was updated.

[cmsbuild]

Pull request #2099 was updated.

[smuzaffar]

looks good, lets get this in