Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow manual override to PR test results #2096

Closed
wants to merge 1 commit into from
Closed

Allow manual override to PR test results #2096

wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

As discussed here: cms-sw/cmssw#43143

@iarspider iarspider requested a review from smuzaffar October 30, 2023 15:36
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@iarspider, @aandvalenzuela, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #2096 was updated.

@iarspider
Copy link
Contributor Author

hold
I still need to figure out how to properly register the new labels in add-externals-gh-labels.py.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Oct 30, 2023
smuzaffar
smuzaffar reviewed Oct 31, 2023
View reviewed changes
githublabels.py Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Oct 31, 2023
View reviewed changes
githublabels.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2096 was updated.

smuzaffar
smuzaffar reviewed Oct 31, 2023
View reviewed changes
githublabels.py Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Oct 31, 2023
View reviewed changes
process_pr.py Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Oct 31, 2023
View reviewed changes
process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2096 was updated.

@iarspider
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Oct 31, 2023
@iarspider iarspider mentioned this pull request Oct 31, 2023
Merged
@smuzaffar smuzaffar mentioned this pull request Nov 1, 2023
Closed
smuzaffar
smuzaffar reviewed Nov 1, 2023
View reviewed changes
process_pr.py Outdated
reason = ""

if reason:
signatures["tests"] = "override-" + reason
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

override- is not needed any more ... right?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2023

Pull request #2096 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

Pull request #2096 was updated.

@iarspider
Copy link
Contributor Author

hold
needs one final test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Nov 3, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

Pull request #2096 was updated.

2 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

Pull request #2096 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

Pull request #2096 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2096 was updated.

@iarspider
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Nov 6, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2096 was updated.

2 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2096 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2096 was updated.

@iarspider iarspider force-pushed the test-manual-approve branch from b06b208 to ead3af7 Compare November 6, 2023 08:04
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2096 was updated.

@iarspider iarspider closed this Nov 6, 2023
@iarspider
Copy link
Contributor Author

#2106

@iarspider iarspider deleted the test-manual-approve branch November 6, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarspider @cmsbuild @smuzaffar