Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual override to PR test results #2106

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

A new Pull Request was created by @iarspider for branch master.

@smuzaffar, @iarspider, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

Resolves cms-sw/cmssw#43143

process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2106 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2106 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

Pull request #2106 was updated.

process_pr.py Outdated

if reason:
override_tests_failure = reason
set_comment_emoji(comment.id, repository)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , please call these set_comment_emoji() only if not dryRun

process_pr.py Outdated Show resolved Hide resolved
process_pr.py Outdated Show resolved Hide resolved
process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2023

Pull request #2106 was updated.

@smuzaffar
Copy link
Contributor

looks good to go in

@smuzaffar smuzaffar merged commit e0e7895 into master Nov 7, 2023
3 of 4 checks passed
@iarspider iarspider deleted the test-manual-approve-2 branch November 7, 2023 10:52
iarspider added a commit to cms-sw/cms-sw.github.io that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants