feat(claim.go): add bundleReference property #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref cnabio/cnab-spec#299 Signed-off-by: Vaughn Dice <vadice@microsoft.com>
7 tasks
radu-matei
reviewed
Mar 3, 2020
| Created time.Time `json:"created"` | ||
| Modified time.Time `json:"modified"` | ||
| Bundle *bundle.Bundle `json:"bundle"` | ||
| BundleReference string `json:"bundleReference,omitempty"` |
There was a problem hiding this comment.
Could we update the test for claims?
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
vdice
force-pushed
the
feat/claim-bundle-reference
branch
from
4ce7458 to
6a4841f
Compare
radu-matei
approved these changes
Mar 3, 2020
|
It looks like the claim schema is not up-to-date 😅 |
silvin-lubecki
approved these changes
Mar 4, 2020
|
Ok my bad the PR is here cnabio/cnab-spec#341 thank you @vdice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundleReferenceproperty to a ClaimRef cnabio/cnab-spec#299