Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(claim.go): add bundleReference property #189

Merged
merged 2 commits into from
Mar 4, 2020
Merged

feat(claim.go): add bundleReference property #189

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8590d94
feat(claim.go): add bundleReference property
vdice Mar 2, 2020
6a4841f
feat(claim_test.go): add bundleReference to exampleClaim
vdice Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions claim/claim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,15 @@ const (
// provide the necessary data to upgrade and uninstall
// a CNAB package.
type Claim struct {
SchemaVersion schemaversion.SchemaVersion `json:"schemaVersion"`
Installation string `json:"installation"`
Revision string `json:"revision"`
Created time.Time `json:"created"`
Modified time.Time `json:"modified"`
Bundle *bundle.Bundle `json:"bundle"`
Result Result `json:"result,omitempty"`
Parameters map[string]interface{} `json:"parameters,omitempty"`
SchemaVersion schemaversion.SchemaVersion `json:"schemaVersion"`
Installation string `json:"installation"`
Revision string `json:"revision"`
Created time.Time `json:"created"`
Modified time.Time `json:"modified"`
Bundle *bundle.Bundle `json:"bundle"`
BundleReference string `json:"bundleReference,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the test for claims?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call; updated.

Result Result `json:"result,omitempty"`
Parameters map[string]interface{} `json:"parameters,omitempty"`
// Outputs is a map from the names of outputs (defined in the bundle) to the contents of the files.
Outputs map[string]interface{} `json:"outputs,omitempty"`
Custom interface{} `json:"custom,omitempty"`
Expand Down