Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename imports to cnabio/cnab-to-oci #94

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

silvin-lubecki
Copy link
Collaborator

image

@carolynvs
Copy link
Collaborator

When we moved porter over to a new import path, it helped to have canonical import paths defined in doc.go files, e.g.

doc.go

package remotes // import "github.com/cnabio/cnab-to-oci/remotes"

This helped us quickly tell while updating code when we had imported/vendored accidentally from the old location and the new location. Just a suggestion that may help downstream consumers of this lib when migrating.

@silvin-lubecki
Copy link
Collaborator Author

PTAL @carolynvs

Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just one question. Should the /converter and /relocation packages get doc.go files with import statements as well?

@silvin-lubecki
Copy link
Collaborator Author

Thanks @carolynvs , just added the missing doc.go files + squashed.

Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦐 it

Update doc.go with canonical import

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@silvin-lubecki
Copy link
Collaborator Author

Rebased

@silvin-lubecki silvin-lubecki merged commit c9599a0 into cnabio:master Feb 13, 2020
@silvin-lubecki silvin-lubecki deleted the rename-imports branch February 13, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants