-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename imports to cnabio/cnab-to-oci #94
Conversation
silvin-lubecki
commented
Feb 11, 2020
a058f21
to
110339a
Compare
When we moved porter over to a new import path, it helped to have canonical import paths defined in doc.go package remotes // import "github.com/cnabio/cnab-to-oci/remotes" This helped us quickly tell while updating code when we had imported/vendored accidentally from the old location and the new location. Just a suggestion that may help downstream consumers of this lib when migrating. |
PTAL @carolynvs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, just one question. Should the /converter and /relocation packages get doc.go files with import statements as well?
1e8af1d
to
e23958f
Compare
Thanks @carolynvs , just added the missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦐 it
Update doc.go with canonical import Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
e23958f
to
b4100ec
Compare
Rebased |