Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update organization files to meet cnabio requirements #90

Open
3 of 6 tasks
silvin-lubecki opened this issue Feb 11, 2020 · 6 comments
Open
3 of 6 tasks

Update organization files to meet cnabio requirements #90

silvin-lubecki opened this issue Feb 11, 2020 · 6 comments

Comments

@silvin-lubecki
Copy link
Collaborator

silvin-lubecki commented Feb 11, 2020

@silvin-lubecki
Copy link
Collaborator Author

^ @vdice Can I let you handle the release note script?

@vdice
Copy link
Member

vdice commented Feb 12, 2020

@silvin-lubecki Here is an example of the script we use in Brigade: https://github.com/brigadecore/brigade/blob/master/brigade.js#L166-L173

It is a combination of shell (git cli and github-release cli invocations) to derive the commits since the last tag and then create the GH release. Unfortunately, the latter github-release tool appears to be unmaintained. There is a security patch I've PRed that has garnered no attention and, after a recent use, I received an email from GitHub indicating that the CLI's way of appending the token as a query parameter is deprecated and will be invalidated by July of this year (instead, the token should be placed in an Authorization header). I might play around with forking the project and making that refactor... but we should also investigate other CLIs we can use in its stead. edit: the latter issue was a straightforward fix: vdice/github-release#1

@silvin-lubecki
Copy link
Collaborator Author

Thank you @vdice, do you suggest then that we should use your fork?

@vdice
Copy link
Member

vdice commented Feb 12, 2020

@silvin-lubecki let's save the fork approach for a plan B... meanwhile, I'm looking into an alternate tool that looks to have more recent activity: https://github.com/tcnksm/ghr . I'll test this out and report back...

Longer term, it looks like https://github.com/cli/cli will end up being the best choice (assuming creation/maintenance of releases will be added.)

@vdice vdice mentioned this issue Feb 12, 2020
1 task
@vdice
Copy link
Member

vdice commented Feb 12, 2020

@silvin-lubecki the ghr cli referenced above looks good; tested well on a project of mine. PR adding to the circleci config in #97

@carolynvs
Copy link
Collaborator

Looks like @vdice is destined to be a contributor to the gh CLI 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants