-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add release job #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me, thank you @vdice !! We should give it a try yes.
@silvin-lubecki my attempts at testing on my fork have been thwarted by failures in the initial |
@silvin-lubecki this should be ready to re-test once some of the dependent PRs are merged (#95, #97)... let's check back in when ready and I can rebase, etc. |
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
😱 I think it's working! Note the new Turns out it appears that enabling workflows are a prereq for GH checks, hence the addition in this PR: |
As for testing the new The configuration looks good according to https://circleci.com/blog/publishing-to-github-releases-via-circleci/#plain-circleci-2.0-example |
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a circleci expert, but so far LGTM
@vdice I removed the old check and added the |
Oh crap I should have squashed before merging 🤦♂ |
Oops! My fault for not condensing commits beforehand 😅 . |
Adding in Draft as I'm a circleci newbie! Cobbled together after quick looks at docs/examples... Perhaps @silvin-lubecki can lend a hand in review/testing/etc. ?
TODO:
GITHUB_TOKEN
env var to the circleci project config that therelease
job can use, with the value of a valid github token for creating releases on this repo.Contributes towards #90