Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add release job #97

Merged
merged 8 commits into from
Feb 17, 2020
Merged

feat(ci): add release job #97

merged 8 commits into from
Feb 17, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 12, 2020

  • adds a release job to the current circleci config

Adding in Draft as I'm a circleci newbie! Cobbled together after quick looks at docs/examples... Perhaps @silvin-lubecki can lend a hand in review/testing/etc. ?

TODO:

  • add an GITHUB_TOKEN env var to the circleci project config that the release job can use, with the value of a valid github token for creating releases on this repo.

Contributes towards #90

Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thank you @vdice !! We should give it a try yes.

@vdice
Copy link
Member Author

vdice commented Feb 12, 2020

@silvin-lubecki my attempts at testing on my fork have been thwarted by failures in the initial build job, as in https://circleci.com/gh/vdice/cnab-to-oci/4. I'm also unable to run make all-ci locally successfully 😅 ... edit: oh, need to update import paths, etc., as is done in #95

@vdice
Copy link
Member Author

vdice commented Feb 12, 2020

@silvin-lubecki this should be ready to re-test once some of the dependent PRs are merged (#95, #97)... let's check back in when ready and I can rebase, etc.

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice
Copy link
Member Author

vdice commented Feb 14, 2020

😱 I think it's working! Note the new main CircleCI GH Check and link. We should be good to now remove the old status webhook (ci/circleci: build) from https://github.com/cnabio/cnab-to-oci/settings/hooks. <-- I'll defer to @radu-matei or @silvin-lubecki to do so.

Turns out it appears that enabling workflows are a prereq for GH checks, hence the addition in this PR:

Screen Shot 2020-02-14 at 12 22 05 PM

@vdice
Copy link
Member Author

vdice commented Feb 14, 2020

As for testing the new release job... I'll need pointers from those more familiar w/ CircleCI on how to test before an actual tag push. Or, we just test it live on the next tag push and adjust if need be 😅 .

The configuration looks good according to https://circleci.com/blog/publishing-to-github-releases-via-circleci/#plain-circleci-2.0-example

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a circleci expert, but so far LGTM

@silvin-lubecki
Copy link
Collaborator

@vdice I removed the old check and added the main one as required. Thank you so much for investigating this 👍

@silvin-lubecki silvin-lubecki merged commit aefa922 into cnabio:master Feb 17, 2020
@silvin-lubecki
Copy link
Collaborator

Oh crap I should have squashed before merging 🤦‍♂

@vdice
Copy link
Member Author

vdice commented Feb 18, 2020

Oops! My fault for not condensing commits beforehand 😅 .

@vdice vdice deleted the ci/release branch February 18, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants