Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github.go): supply access token via authz header per GH api #1

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

vdice
Copy link
Owner

@vdice vdice commented Feb 12, 2020

Updates api usage to supply the access token in the form of an Authorization header as opposed to a query parameter, as informed by GitHub:

On February 12th, 2020 at 16:28 (UTC) your personal access token (general curl token) using Go-http-client/1.1 was used as part of a query parameter to access an endpoint through the GitHub API:

Please use the Authorization HTTP header instead, as using the `access_token` query parameter is deprecated and will be removed July 1st, 2020.

Tested via building the cli (make) and issuing an info command, e.g. ./github-release info -u brigadecore -r brigade. (Command works and no email response from GH received.)

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant