Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

WIP: Push pull to image registry #442

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP: Push pull to image registry #442

wants to merge 5 commits into from

Commits on Nov 16, 2018

  1. Signing a bundle now imply resolving image references into immutable … 

    …references

This aims at having signed bundles truly immutable. That means that all referenced images (invocationImages or images) without a digest are modified into digested references:
- if an image is available in the docker engine, and it has already a RepoDigest, we use it
- if an image is not available in the docker engine, we pull it and get its RepoDigest
- if an image is available in the docker engine, but has no RepoDigest, we consider that it has been built locally and has not yet been pushed. In that case we fail, and tell the user to push it.

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
    @simonferquel
    simonferquel committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    e0937c3 View commit details
    Browse the repository at this point in the history

  2. Linting + better bundle_sign implementation 

    Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
    @simonferquel
    simonferquel committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    3445e01 View commit details
    Browse the repository at this point in the history

  3. Add push-local-images to bundle sign 

    Also fix an issue with key generation on Windows

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
    @simonferquel
    simonferquel committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    af3e7d5 View commit details
    Browse the repository at this point in the history

  4. Refined index UX 

    Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
    @simonferquel
    simonferquel committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    08c3ee0 View commit details
    Browse the repository at this point in the history

  5. Add Push/Pull from an image registry 

    Introduced `duffle bundle push/pull` to work with a registry,
leveraging genuinetools/reg.

For now we create a Manifest with a config mediatype fixed to docker
image, because registries only accept a limited number of config types
in their validation logic. Once they accept custom config types, we will
be able to change that.

Also, cross-repository references cannot be modelled in a registry
manifest, which makes it impossible to create images references at the
manifest level. We need to dig into that with docker/distribution team.

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
    @simonferquel
    simonferquel committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    2012652 View commit details
    Browse the repository at this point in the history