This repository has been archived by the owner on May 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
WIP: Push pull to image registry #442
Open
simonferquel
wants to merge
5
commits into
cnabio:master
Choose a base branch
from
simonferquel:push-pull-to-registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e0937c3
Signing a bundle now imply resolving image references into immutable …
simonferquel 3445e01
Linting + better bundle_sign implementation
simonferquel af3e7d5
Add push-local-images to bundle sign
simonferquel 08c3ee0
Refined index UX
simonferquel 2012652
Add Push/Pull from an image registry
simonferquel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
package main | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"io" | ||
"io/ioutil" | ||
"os" | ||
"path/filepath" | ||
"strings" | ||
|
||
"github.com/docker/cli/cli/command" | ||
"github.com/docker/cli/cli/flags" | ||
"github.com/spf13/cobra" | ||
|
||
"github.com/deis/duffle/pkg/crypto/digest" | ||
"github.com/deis/duffle/pkg/duffle/home" | ||
"github.com/deis/duffle/pkg/image" | ||
) | ||
|
||
func newBundlePullCmd(w io.Writer) *cobra.Command { | ||
cmd := &cobra.Command{ | ||
Use: "pull BUNDLE", | ||
Short: "pull a bundle from an image registry", | ||
Args: cobra.ExactArgs(1), | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
cli := command.NewDockerCli(os.Stdin, os.Stdout, os.Stderr, false) | ||
if err := cli.Initialize(flags.NewClientOptions()); err != nil { | ||
return err | ||
} | ||
signedBundle, err := image.PullBundle(context.TODO(), cli, args[0]) | ||
if err != nil { | ||
return err | ||
} | ||
sha, err := digest.OfBuffer(signedBundle) | ||
if err != nil { | ||
return fmt.Errorf("cannot compute digest from bundle: %v", err) | ||
} | ||
|
||
h := home.Home(homePath()) | ||
fpath := filepath.Join(h.Bundles(), sha) | ||
if err := ioutil.WriteFile(fpath, signedBundle, 0644); err != nil { | ||
return err | ||
} | ||
|
||
parts := strings.Split(args[0], ":") | ||
if len(parts) != 2 { | ||
return fmt.Errorf("%s is of a wrong format, must be repo:tag", args[0]) | ||
} | ||
name, version := parts[0], parts[1] | ||
return recordBundleReference(h, name, version, sha) | ||
}, | ||
} | ||
return cmd | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
package main | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"io" | ||
"io/ioutil" | ||
"os" | ||
"path/filepath" | ||
"strings" | ||
|
||
"github.com/docker/cli/cli/command" | ||
"github.com/docker/cli/cli/flags" | ||
"github.com/spf13/cobra" | ||
|
||
"github.com/deis/duffle/pkg/duffle/home" | ||
"github.com/deis/duffle/pkg/image" | ||
"github.com/deis/duffle/pkg/repo" | ||
) | ||
|
||
func newBundlePushCmd(w io.Writer) *cobra.Command { | ||
cmd := &cobra.Command{ | ||
Use: "push BUNDLE", | ||
Short: "push a bundle to an image registry", | ||
Args: cobra.ExactArgs(1), | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
parts := strings.Split(args[0], ":") | ||
if len(parts) != 2 { | ||
return fmt.Errorf("%s is of a wrong format, must be repo:tag", args[0]) | ||
} | ||
name, version := parts[0], parts[1] | ||
h := home.Home(homePath()) | ||
index, err := repo.LoadIndex(h.Repositories()) | ||
if err != nil { | ||
return err | ||
} | ||
sha, err := index.Get(name, version) | ||
if err != nil { | ||
return err | ||
} | ||
fpath := filepath.Join(h.Bundles(), sha) | ||
data, err := ioutil.ReadFile(fpath) | ||
if err != nil { | ||
return err | ||
} | ||
cli := command.NewDockerCli(os.Stdin, os.Stdout, os.Stderr, false) | ||
if err := cli.Initialize(flags.NewClientOptions()); err != nil { | ||
return err | ||
} | ||
digest, err := image.PushBundle(context.TODO(), cli, data, args[0]) | ||
if err != nil { | ||
return err | ||
} | ||
fmt.Println("Digest of manifest is", digest) | ||
return nil | ||
}, | ||
} | ||
return cmd | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍