-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename import package to reflect future org change to cnabio
#42
Conversation
CI is failing because the import path for the package does not match the directory structure in However, cloning in the correct directory works:
Do we want to first move the repo under the new organization, then merge this PR? |
This needs a rebase on top of #47. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
3253f5c
to
e243fd5
Compare
Signed-off-by: Radu M <root@radu.sh>
Rebased on top #47. |
mkdir -p $GOPATH/src/github.com/$GITHUB_REPOSITORY | ||
mv $(pwd)/* $GOPATH/src/github.com/$GITHUB_REPOSITORY | ||
cd $GOPATH/src/github.com/$GITHUB_REPOSITORY | ||
export GOPATH=$HOME/go && export GOBIN=$(go env GOPATH)/bin && export PATH=$PATH:$GOPATH&& export PATH=$PATH:$GOBIN && mkdir -p $GOBIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we might want to tweak the Makefile
to not need a GOPATH
anymore, I'll open a separate issue about it.
@@ -75,7 +75,7 @@ INFO[0001] The software product passed all verification. | |||
cmd.Flags().StringVarP(&verify.localFile, "local", "", "", "Local file to validate the SHA256 against (mandatory for thick bundles)") | |||
|
|||
cmd.Flags().BoolVarP(&verify.intoto, "in-toto", "", false, "If passed, will try to fetch in-toto metadata from TUF and perform the verification") | |||
cmd.Flags().StringVarP(&verify.verificationImage, "image", "", "docker.pkg.github.com/engineerd/in-toto-container/verification:v1", "container image to run the in-toto verification") | |||
cmd.Flags().StringVarP(&verify.verificationImage, "image", "", "docker.pkg.github.com/cnabio/in-toto-container/verification:v1", "container image to run the in-toto verification") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also means we must push the verification image to cnabio
.
This PR is preparing the moving of this repo into github.com/cnabio, the official GitHub organization for CNAB projects.
This PR:
github.com/engineerd/signy
github.com/cnabio/signy
.