Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go modules #47

Merged
merged 5 commits into from
Feb 7, 2020
Merged

Add Go modules #47

merged 5 commits into from
Feb 7, 2020

Conversation

radu-matei
Copy link
Member

This PR adds support for Go modules.
While it removes the vendor/ directory from the tree, it doesn't remove the dep files just yet.

Radu M added 4 commits February 6, 2020 18:05
Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
@radu-matei
Copy link
Member Author

radu-matei commented Feb 7, 2020

Tests are passing, this still needs:

  • to enable modules for Azure Pipelines
  • to change the bootstrap target to skip dep check.

Signed-off-by: Radu M <root@radu.sh>
@radu-matei
Copy link
Member Author

We should also update Go to 1.13, but I would defer this to another PR.

Copy link

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants