Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/push to docker hub #70

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Feature/push to docker hub #70

merged 4 commits into from
Oct 31, 2023

Conversation

Topin2001
Copy link
Contributor

@Topin2001 Topin2001 commented Oct 31, 2023

Proposed changes

The idea is to deploy the docker image into docker hub, when a new release is created

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

  • Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I have read the CONTRIBUTING doc
  • [ x] I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • Codacy validates the quality of the modifications
  • [x ] GitHub Actions CI workflow passes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@@ -46,7 +46,7 @@ jobs:
# Job that tests the image
test:
name: Test the Docker image
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une bonne pratique est d'éviter les "latest" dans une intégration continue, cela permet d'avoir des CI reproductible, on va préférer figer une version (a minima, figer la version majeure pour bénificer des patchs de sécu tout de même)

Si besoin d'un ubuntu plus récent, tu peux mettre ubuntu-22.04 ou 23.10. ubuntu a de plus une sacré tendance a casser plein de trucs d'une version majeure a l'autre :)

@Topin2001 Topin2001 added this to the 3.0.1 milestone Oct 31, 2023
@Topin2001 Topin2001 merged commit 994eac2 into cnescatlab:develop Oct 31, 2023
3 checks passed
@gbonnefille
Copy link
Contributor

@Topin2001 did you plan to do the same thing on https://github.com/cnescatlab/sonarqube and https://github.com/cnescatlab/sonar-scanner?

I opened an issue cnescatlab/sonarqube-catlab#40 and started a PR cnescatlab/sonarqube-catlab#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants