Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Create docker-publish.yml #41

Merged

Conversation

gbonnefille
Copy link
Contributor

Proposed changes

Publish Docker images from master branch.

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Needed to automatically publish the Docker image
@gbonnefille
Copy link
Contributor Author

@louisjdmartin any opinion on this?

@louisjdmartin
Copy link
Member

It's planned to push everything on docker hub (currently, images on there are pretty old because... nobody push new releases => https://hub.docker.com/r/lequal/sonarqube )

@Topin2001 as you work on docker-cat CI, can you check this PR ? And eventually adapt-it to push on our docker hub registry (by changing URL and environment variables if needed)

@louisjdmartin
Copy link
Member

PS: @gbonnefille Thanks for this PR :)

@louisjdmartin louisjdmartin added the enhancement New feature or request label Nov 6, 2023
@gbonnefille
Copy link
Contributor Author

PS: @gbonnefille Thanks for this PR :)

You're welcome. This project is really useful and it deserve an up-to-date Docker image.

@Topin2001 Topin2001 added this to the 3.0.2 milestone Nov 23, 2023
@louisjdmartin louisjdmartin merged commit 524ca19 into cnescatlab:develop Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish recent Docker image
3 participants