-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
intentresolver: fix testrace flake by extending timeouts
The unit tests which failed assumed that all messages intents in a single call to ResolveIntents could be queued within the batch timeout and idle window which is by default rather short (10 and 5 ms respectively). The testing validation logic is rather strict and assumes that the batch will fire due to size rather than time constraints. The fix is to allow the test to increase these values to make the test more robust to load. Before this change the flake was reproducible running testrace within several hundred iterations. Running testrace now seems to not provoke any failures. All that being said, I can see an argument that the testing logic should be made less rigid and should accept that the batches may be split up. Fixes #35064. Release note: None
- Loading branch information
Showing
2 changed files
with
52 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters