teamcity: failed test: TestCleanupIntents #35064
Assignees
Labels
Milestone
Comments
cockroach-teamcity
added
C-test-failure
|
@ajwerner looks related to the new |
|
Bummer. Yes I’ll deal with it. |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Feb 20, 2019
The unit tests which failed assumed that all messages intents in a single call to ResolveIntents could be queued within the batch timeout and idle window which is by default rather short (10 and 5 ms respectively). The testing validation logic is rather strict and assumes that the batch will fire due to size rather than time constraints. The fix is to allow the test to increase these values to make the test more robust to load. Before this change the flake was reproducible running testrace within several hundred iterations. After the test it has not failed after running over 20k test race iterations from two concurrently running executions. Fixes cockroachdb#35064. Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Feb 20, 2019
The unit tests which failed assumed that all messages intents in a single call to ResolveIntents could be queued within the batch timeout and idle window which is by default rather short (10 and 5 ms respectively). The testing validation logic is rather strict and assumes that the batch will fire due to size rather than time constraints. The fix is to allow the test to increase these values to make the test more robust to load. Before this change the flake was reproducible running testrace within several hundred iterations. Running testrace now seems to not provoke any failures. All that being said, I can see an argument that the testing logic should be made less rigid and should accept that the batches may be split up. Fixes cockroachdb#35064. Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Feb 20, 2019
The unit tests which failed assumed that all messages intents in a single call to ResolveIntents could be queued within the batch timeout and idle window which is by default rather short (10 and 5 ms respectively). The testing validation logic is rather strict and assumes that the batch will fire due to size rather than time constraints. The fix is to allow the test to increase these values to make the test more robust to load. Before this change the flake was reproducible running testrace within several hundred iterations. Running testrace now seems to not provoke any failures. All that being said, I can see an argument that the testing logic should be made less rigid and should accept that the batches may be split up. Fixes cockroachdb#35064. Release note: None
craig bot
pushed a commit
that referenced
this issue
Feb 21, 2019
35085: intentresolver: fix testrace flake by extending timeouts r=ajwerner a=ajwerner The unit tests which failed assumed that all messages intents in a single call to ResolveIntents could be queued within the batch timeout and idle window which is by default rather short (10 and 5 ms respectively). The testing validation logic is rather strict and assumes that the batch will fire due to size rather than time constraints. The fix is to allow the test to increase these values to make the test more robust to load. Before this change the flake was reproducible running testrace within several hundred iterations. After the test it has not failed after running over 20k test race iterations from two concurrently running executions. Fixes #35064. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following tests appear to have failed on master (testrace): TestCleanupIntents/#2, TestCleanupIntents/#00, TestCleanupIntents/#1, TestCleanupIntents
You may want to check for open issues.
#1144299:
Please assign, take a look and update the issue accordingly.
The text was updated successfully, but these errors were encountered: