Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiraft: snapshot/compaction integration #228

Closed
bdarnell opened this issue Dec 16, 2014 · 2 comments
Closed

Multiraft: snapshot/compaction integration #228

bdarnell opened this issue Dec 16, 2014 · 2 comments
Assignees
@bdarnell
Milestone
Beta

Comments

@bdarnell
Copy link
Contributor

We need to be able to produce and apply snapshots so we can garbage collect the raft logs. This will work somewhat differently from MemoryStorage: We can synthesize snapshots on-demand in the Storage.Snapshot method instead of tying snapshot creation to an explicit Compact call. We can then advance Storage.FirstIndex whenever we discard old log entries.
@andybons andybons modified the milestone: v0.1 (Beta) Jan 13, 2015
@bdarnell bdarnell mentioned this issue Jan 16, 2015
Closed
@bdarnell bdarnell self-assigned this Jan 16, 2015
@spencerkimball
Copy link
Member

@bdarnell is this still open?

@bdarnell
Copy link
Contributor Author

This is done.

@rohany rohany mentioned this issue Sep 18, 2019
Merged
rohany pushed a commit to rohany/cockroach that referenced this issue Sep 18, 2019
demo: Add telemetry about usage of new demo features.
c4465cd 
This PR adds telemetry for some of the new features added to cockroach
demo (nodes, with-load, localities, geo-partitioned-replicas).

It isn't straight forward how to test this, as there seems to be a race
between the background thread that flushes telemetry and actually
querying for the counter's values on startup.

Work towards cockroachdb#228.

Release justification: Low risk monitoring improvement.

Release note: None
rohany pushed a commit to rohany/cockroach that referenced this issue Sep 18, 2019
demo: Add telemetry about usage of new demo features.
61fd06a 
This PR adds telemetry for some of the new features added to cockroach
demo (nodes, with-load, localities, geo-partitioned-replicas).

It isn't straight forward how to test this, as there seems to be a race
between the background thread that flushes telemetry and actually
querying for the counter's values on startup.

Work towards cockroachdb#228.

Release justification: Low risk monitoring improvement.

Release note: None
craig bot pushed a commit that referenced this issue Sep 18, 2019
Merge #40883
33eb2c0 
40883: demo: Add telemetry about usage of new demo features. r=jordanlewis a=rohany

This PR adds telemetry for some of the new features added to cockroach
demo (nodes, with-load, localities, geo-partitioned-replicas).

It isn't straight forward how to test this, as there seems to be a race
between the background thread that flushes telemetry and actually
querying for the counter's values on startup.

Work towards #228.

Release justification: Low risk monitoring improvement.

Release note: None

Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdarnell bdarnell

Labels
None yet
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
3 participants
@bdarnell @andybons @spencerkimball