demo: Add telemetry about usage of new demo features. #40883
Merged
+71
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
force-pushed
the
demo-telemetry
branch
from
98344c2
to
c4465cd
Compare
jordanlewis
reviewed
Sep 18, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @rohany)
pkg/cli/demo_telemetry.go, line 21 at r1 (raw file):
type demoTelemetry int const (
Add comments to this stuff even though it's kind of trivial. Just mention that it corresponds to the flags to demo.
This PR adds telemetry for some of the new features added to cockroach demo (nodes, with-load, localities, geo-partitioned-replicas). It isn't straight forward how to test this, as there seems to be a race between the background thread that flushes telemetry and actually querying for the counter's values on startup. Work towards cockroachdb#228. Release justification: Low risk monitoring improvement. Release note: None
rohany
force-pushed
the
demo-telemetry
branch
from
c4465cd
to
61fd06a
Compare
rohany
commented
Sep 18, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/cli/demo_telemetry.go, line 21 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
Add comments to this stuff even though it's kind of trivial. Just mention that it corresponds to the flags to demo.
Done.
jordanlewis
approved these changes
Sep 18, 2019
|
bors r=jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
Sep 18, 2019
40883: demo: Add telemetry about usage of new demo features. r=jordanlewis a=rohany This PR adds telemetry for some of the new features added to cockroach demo (nodes, with-load, localities, geo-partitioned-replicas). It isn't straight forward how to test this, as there seems to be a race between the background thread that flushes telemetry and actually querying for the counter's values on startup. Work towards #228. Release justification: Low risk monitoring improvement. Release note: None Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds telemetry for some of the new features added to cockroach
demo (nodes, with-load, localities, geo-partitioned-replicas).
It isn't straight forward how to test this, as there seems to be a race
between the background thread that flushes telemetry and actually
querying for the counter's values on startup.
Work towards #228.
Release justification: Low risk monitoring improvement.
Release note: None