Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamcity: failed test: TestStoreRangeMergeSlowAbandonedFollower #32590

Closed
cockroach-teamcity opened this issue Nov 26, 2018 · 1 comment
Closed

teamcity: failed test: TestStoreRangeMergeSlowAbandonedFollower #32590

cockroach-teamcity opened this issue Nov 26, 2018 · 1 comment
Assignees
@benesch
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
19.1

Comments

@cockroach-teamcity
Copy link
Member

The following tests appear to have failed on master (test): TestStoreRangeMergeSlowAbandonedFollower

You may want to check for open issues.

#1025428:

TestStoreRangeMergeSlowAbandonedFollower
...ip/client.go:129  [n3] started gossip client to 127.0.0.1:44567
I181126 12:35:35.148210 46594 gossip/client.go:134  [n3] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:35.815867 46714 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:35.816262 46714 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:36.147887 46739 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:44567
I181126 12:35:36.148538 46739 gossip/client.go:134  [n3] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:36.816209 46742 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:36.816889 46742 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:37.148184 46716 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:34853
I181126 12:35:37.148752 46716 gossip/client.go:134  [n3] closing client to n2 (127.0.0.1:34853): stopping outgoing client to n2 (127.0.0.1:34853); already have incoming
I181126 12:35:37.816424 46719 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:37.817090 46719 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:38.148579 46748 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:44567
I181126 12:35:38.149189 46748 gossip/client.go:134  [n3] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:38.816680 46667 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:38.817190 46667 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:39.149106 46682 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:44567
I181126 12:35:39.151400 46682 gossip/client.go:134  [n3] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:39.816868 46669 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:39.817432 46669 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:40.149428 46703 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:34853
I181126 12:35:40.150294 46703 gossip/client.go:134  [n3] closing client to n2 (127.0.0.1:34853): stopping outgoing client to n2 (127.0.0.1:34853); already have incoming
I181126 12:35:40.817244 46756 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:40.818592 46756 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:41.149757 46529 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:44567
I181126 12:35:41.150469 46529 gossip/client.go:134  [n3] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:41.817488 46735 gossip/client.go:129  [n2] started gossip client to 127.0.0.1:44567
I181126 12:35:41.818760 46735 gossip/client.go:134  [n2] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming
I181126 12:35:42.150060 46687 gossip/client.go:129  [n3] started gossip client to 127.0.0.1:44567
I181126 12:35:42.150721 46687 gossip/client.go:134  [n3] closing client to n1 (127.0.0.1:44567): stopping outgoing client to n1 (127.0.0.1:44567); already have incoming

Please assign, take a look and update the issue accordingly.
@cockroach-teamcity cockroach-teamcity added this to the 2.2 milestone Nov 26, 2018
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Nov 26, 2018
@tbg
Copy link
Member

tbg commented Nov 26, 2018 

client_merge_test.go:1833: storage/replica_command.go:595: merge of range into 1 failed: waiting for all right-hand replicas to catch up: rpc error: code = DeadlineExceeded desc = context deadline exceeded

Haven't looked in detail, but could just have hit the 10s (?) timeout we have on this req.

benesch added a commit to benesch/cockroach that referenced this issue Nov 26, 2018
@benesch
storage: deflake TestStoreRangeMergeSlowAbandonedFollower
6e9bc2d 
This test needs to wait for store2 to process the split before it blocks
traffic to the LHS of the merge. The old approach admitted a race where
it would proceed before store2's replica of the RHS was initialized.

Fix cockroachdb#32590.

Release note: None
@benesch benesch mentioned this issue Nov 26, 2018
Merged
craig bot pushed a commit that referenced this issue Nov 26, 2018
@benesch
Merge #32609
2ddc528 
32609: storage: deflake TestStoreRangeMergeSlowAbandonedFollower r=tschottdorf a=benesch

This test needs to wait for store2 to process the split before it blocks
traffic to the LHS of the merge. The old approach admitted a race where
it would proceed before store2's replica of the RHS was initialized.

Fix #32590.

Release note: None

Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
@craig craig bot closed this as completed in #32609 Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesch benesch

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
3 participants
@benesch @tbg @cockroach-teamcity