storage: deflake TestStoreRangeMergeSlowAbandonedFollower #32609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test needs to wait for store2 to process the split before it blocks traffic to the LHS of the merge. The old approach admitted a race where it would proceed before store2's replica of the RHS was initialized. Fix cockroachdb#32590. Release note: None
|
This change is |
tbg
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
Many thanks! 🙇 bors r=tschottdorf |
craig bot
pushed a commit
that referenced
this pull request
Nov 26, 2018
32609: storage: deflake TestStoreRangeMergeSlowAbandonedFollower r=tschottdorf a=benesch This test needs to wait for store2 to process the split before it blocks traffic to the LHS of the merge. The old approach admitted a race where it would proceed before store2's replica of the RHS was initialized. Fix #32590. Release note: None Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test needs to wait for store2 to process the split before it blocks
traffic to the LHS of the merge. The old approach admitted a race where
it would proceed before store2's replica of the RHS was initialized.
Fix #32590.
Release note: None