Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cockroach user command in favor of SQL statements #33594

Closed
jseldess opened this issue Jan 9, 2019 · 1 comment · Fixed by #43903
Closed

Remove cockroach user command in favor of SQL statements #33594

jseldess opened this issue Jan 9, 2019 · 1 comment · Fixed by #43903
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@jseldess
Copy link
Contributor

jseldess commented Jan 9, 2019

There are two ways to work with users, cockroach user and the CREATE/DROP USER SQL statements. I think this is the only functionality currently exposed via both the cli and SQL. I think we should limit this functionality to SQL, especially given that we moved zone config work from the CLI to SQL.
@jseldess jseldess changed the title Remove cockroach user command in favor of SQL statements Remove cockroach user command in favor of SQL statements Jan 9, 2019
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. A-cli labels Jan 12, 2019
@knz
Copy link
Contributor

knz commented Jan 12, 2019

Probably we should have a release cycle where the feature is:

  • hidden but functional
  • not documented
  • produces a deprecation warning upon use

This was referenced Aug 2, 2019
Closed
Merged
craig bot pushed a commit that referenced this issue Aug 5, 2019
@knz
Merge #39297
bba25cc 
39297: cli: deprecate 'cockroach user' r=knz a=knz

Informs #33594.
As requested by @jseldess, as the functionality in SQL is simpler /
clearer to use (properly differentiates users from roles).

Release note (cli change): The `cockroach user` sub-commands are now
deprecated. Users and roles can be managed using SQL statements
instead. This functionality will be removed in the next release.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@knz knz mentioned this issue Jan 13, 2020
Merged
@craig craig bot closed this as completed in 19e35f9 Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: remove the cockroach user sub-command knz/cockroach
2 participants
@knz @jseldess