cli: deprecate 'cockroach user' #39297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested by @jseldess, as the functionality in SQL is simpler / clearer to use (properly differentiates users from roles). Release note (cli change): The `cockroach user` sub-commands are now deprecated. Users and roles can be managed using SQL statements instead. This functionality will be removed in the next release.
|
This change is |
bdarnell
approved these changes
Aug 5, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jseldess)
|
tfyr bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
39297: cli: deprecate 'cockroach user' r=knz a=knz Informs #33594. As requested by @jseldess, as the functionality in SQL is simpler / clearer to use (properly differentiates users from roles). Release note (cli change): The `cockroach user` sub-commands are now deprecated. Users and roles can be managed using SQL statements instead. This functionality will be removed in the next release. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #33594.
As requested by @jseldess, as the functionality in SQL is simpler /
clearer to use (properly differentiates users from roles).
Release note (cli change): The
cockroach usersub-commands are nowdeprecated. Users and roles can be managed using SQL statements
instead. This functionality will be removed in the next release.