Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add TypeORM canary tests to nightlies to ensure no regressions #35876

Closed
awoods187 opened this issue Mar 18, 2019 · 4 comments
Closed

sql: add TypeORM canary tests to nightlies to ensure no regressions #35876

awoods187 opened this issue Mar 18, 2019 · 4 comments
Assignees
@BramGruneir
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@awoods187
Copy link
Contributor

We should add the TypeORM tests to our nightly suites to make sure we continue to support TypeORM well and to ensure we do not regress any functionality for the tool.
@awoods187 awoods187 added A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. labels Mar 18, 2019
@awoods187 awoods187 mentioned this issue Mar 18, 2019
Closed
@BramGruneir
Copy link
Member

Should I pin the canary test to a specific version of TypeORM or to master?

@BramGruneir BramGruneir self-assigned this Mar 20, 2019
@awoods187
Copy link
Contributor Author

@mjibson used some tool that let you decide dynamically which version of both CRDB and Third-party tool to point at. I think we should do our master and their latest stable (to keep us from breaking anything) and they can handle testing on their side to make sure their new versions don't break our setup.

@maddyblue
Copy link
Contributor

I have a commit here that runs the typeorm cockroach example in docker-compose. It needs a bit of work but is a good starting point to do this in acceptance testing.

BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 21, 2019
@BramGruneir
roachtest: Add TypeORM nightly roachtest.
b5062bf 
Closes cockroachdb#35876.

Release note: None
@BramGruneir
Copy link
Member

Closed via #36003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BramGruneir BramGruneir

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maddyblue @BramGruneir @awoods187