Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: Add TypeORM nightly roachtest. #36003

Merged
merged 1 commit into from
Mar 21, 2019
Merged

roachtest: Add TypeORM nightly roachtest. #36003

merged 1 commit into from
Mar 21, 2019

Conversation

BramGruneir
Copy link
Member

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@BramGruneir
Copy link
Member Author

cc @awoods187

@awoods187
Copy link
Contributor

Awesome--speedy turnaround!

@BramGruneir
Copy link
Member Author

Just added a minor update that fetches the latest TypeORM released version each time.

This way if there is a regression or our side or their side, we'll know right away.

I'm going to do the same for the other canary tests.

@BramGruneir
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 21, 2019

Build failed

@BramGruneir
Copy link
Member Author

bors r+

craig bot pushed a commit that referenced this pull request Mar 21, 2019
@BramGruneir
Merge #36003
b2c83e4 
36003: roachtest: Add TypeORM nightly roachtest. r=BramGruneir a=BramGruneir

Release note: None

Co-authored-by: Bram Gruneir <bram@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Mar 21, 2019

Build succeeded

@craig craig bot merged commit b5062bf into cockroachdb:master Mar 21, 2019
@BramGruneir BramGruneir deleted the typeorm branch March 22, 2019 19:08
@BramGruneir BramGruneir mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddyblue maddyblue maddyblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BramGruneir @cockroach-teamcity @awoods187 @maddyblue