-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exec: vectorized engine incorrectly supports dates outside of range #40354
Comments
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
41662: colexec: add timestamp type r=yuzefovich a=yuzefovich This PR is the rebased version of #40250 with a modification of how we're creating `DTimestamp` in `PhysicalTypeColElemToDatum`. **colexec,coldata: support timestamp type** This commit adds support for the TIMESTAMP type to the coldata and colexec packages. **colexec: add random projection tests for all types** This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in #40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. **colserde: add simple serialization for TIMESTAMP** This commit adds simple (and quite inefficient) serialization for TIMESTAMP type which uses the provided marshalling and unmarshalling methods. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
We have marked this issue as stale because it has been inactive for |
We have marked this issue as stale because it has been inactive for |
logictest/edge
doesn't succeed withauto
if we lower the row count threshold to 0 (meaning if the query is streaming, it'll always be executed with the vectorized engine):What happens is that Matt added the support for date type exactly like postgres has, but in the vectorized land we're using int64. This should be fixed.
Jira issue: CRDB-5547
The text was updated successfully, but these errors were encountered: