release-19.2: colexec: add timestamp type #42416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the TIMESTAMP type to the coldata and colexec packages. Release note (sql change): vectorized execution engine now supports TIMESTAMP type.
|
This change is |
asubiotto
approved these changes
Nov 12, 2019
This test randomly runs binary comparisons against all types with random data, verifying that the result of Datum.Compare matches the result of the exec projection. This found the bug with date infinity matching tracked in cockroachdb#40354, and immediately found a bug with the timestamp implementation in the previous commit, so I'm fairly sure it's a useful random test to have around. Release note: None
This commit adds simple (and quite inefficient) serialization for TIMESTAMP type which uses the provided marshalling and unmarshalling methods. Release note: None
yuzefovich
force-pushed
the
backport19.2-41662
branch
from
b08fab0
to
c90bd07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #41662.
/cc @cockroachdb/release
This PR is the rebased version of #40250 with a modification of how we're creating
DTimestampinPhysicalTypeColElemToDatum.colexec,coldata: support timestamp type
This commit adds support for the TIMESTAMP type to the coldata and colexec
packages.
Release note (sql change): vectorized execution engine now supports
TIMESTAMP type.
colexec: add random projection tests for all types
This test randomly runs binary comparisons against all types with random
data, verifying that the result of Datum.Compare matches the result of
the exec projection.
This found the bug with date infinity matching tracked in #40354, and
immediately found a bug with the timestamp implementation in the
previous commit, so I'm fairly sure it's a useful random test to have
around.
Release note: None
colserde: add simple serialization for TIMESTAMP
This commit adds simple (and quite inefficient) serialization
for TIMESTAMP type which uses the provided marshalling and
unmarshalling methods.
Release note: None