Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-19.2: colexec: add timestamp type #42416

Merged
merged 3 commits into from
Nov 12, 2019
Merged

release-19.2: colexec: add timestamp type #42416

merged 3 commits into from
Nov 12, 2019

Commits on Nov 12, 2019

  1. colexec,coldata: support timestamp type 

    This commit adds support for the TIMESTAMP type to the coldata and colexec
packages.

Release note (sql change): vectorized execution engine now supports
TIMESTAMP type.
    @jordanlewis @yuzefovich
    jordanlewis authored and yuzefovich committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    400cf1d View commit details
    Browse the repository at this point in the history

  2. colexec: add random projection tests for all types 

    This test randomly runs binary comparisons against all types with random
data, verifying that the result of Datum.Compare matches the result of
the exec projection.

This found the bug with date infinity matching tracked in cockroachdb#40354, and
immediately found a bug with the timestamp implementation in the
previous commit, so I'm fairly sure it's a useful random test to have
around.

Release note: None
    @jordanlewis @yuzefovich
    jordanlewis authored and yuzefovich committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    0ebb4ca View commit details
    Browse the repository at this point in the history

  3. colserde: add simple serialization for TIMESTAMP 

    This commit adds simple (and quite inefficient) serialization
for TIMESTAMP type which uses the provided marshalling and
unmarshalling methods.

Release note: None
    @yuzefovich
    yuzefovich committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    c90bd07 View commit details
    Browse the repository at this point in the history