Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: support multi-tenancy #48274

Closed
tbg opened this issue May 1, 2020 · 1 comment
Closed

cdc: support multi-tenancy #48274

tbg opened this issue May 1, 2020 · 1 comment
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc X-anchored-telemetry The issue number is anchored by telemetry references.

Comments

@tbg
Copy link
Member

tbg commented May 1, 2020 •
edited by cockroach-jira-scripts
Loading

We're disabling this in Phase 2 (#48008), mostly due to the DistSQL dependency. Eventually, we may want to allow tenants to run change feeds. We will need to control which external endpoints these feeds can be pointed at.

Epic CRDB-2608

Jira issue: CRDB-4340
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy labels May 1, 2020
@knz knz added the X-anchored-telemetry The issue number is anchored by telemetry references. label Sep 11, 2020
@knz knz mentioned this issue Sep 11, 2020
Merged
craig bot pushed a commit that referenced this issue Sep 14, 2020
@knz
Merge #54256
40f03d9 
54256: sql: make multi-tenancy errors report to telemetry r=asubiotto a=knz

Fixes #48164. 

Issues referenced, I also added the X-anchored-telemetry label to them on github (we keep those issues open on github until their reference in the code is removed):

#54254 
#54255 
#54250 
#54251 
#54252 
#49854 
#48274
#47150
#47971
#47970
#47900 
#47925 


Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@miretskiy
Copy link
Contributor

@amruss -- not sure what the current state is.
I thought we do allow tenants to run changefeeds; though I'm pretty sure we don't
require external connection endpoints (yet).
I assume this issue should stay open? If not, and the remaining work is being
tracked elsewhere, can you please close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc X-anchored-telemetry The issue number is anchored by telemetry references.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knz @tbg @miretskiy @elinorgarcia