Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/catalog: validate that old foreign key representation is not in use #66262

Closed
ajwerner opened this issue Jun 9, 2021 · 1 comment · Fixed by #70636
Closed

sql/catalog: validate that old foreign key representation is not in use #66262

ajwerner opened this issue Jun 9, 2021 · 1 comment · Fixed by #70636
Assignees
@postamar
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Jun 9, 2021

Is your feature request related to a problem? Please describe.

In 19.2 we moved to a new foreign key representation. It took us a long time to migrate off of it. We now, finally, have. Nevertheless, we support restoring backups from versions where it was supported, so we need to keep the representation. This issue is follow-up work to validate that the representation is not used.

Relates to #58611
@ajwerner ajwerner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-schema-descriptors Relating to SQL table/db descriptor handling. labels Jun 9, 2021
@jlinder jlinder added the T-sql-schema-deprecated Use T-sql-foundations instead label Jun 16, 2021
@ajwerner
Copy link
Contributor Author

ajwerner commented Aug 3, 2021

I think this is just for the Validate method on the table descriptor to make sure that these fields are empty. @postamar thinks maybe this has been done.

@postamar postamar mentioned this issue Sep 23, 2021
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Sep 23, 2021
tabledesc: validate that old FK representation is not used
87bbae7 
Previously, pre-19.2, we used to use a different foreign key
representation. We have since then migrated off of it. This commit adds
validation checks to verify that we are no longer using it.

This commit also makes superficial changes to the
catalog.TableDescriptor interface.

Fixes cockroachdb#66262

Release note: None
craig bot pushed a commit that referenced this issue Sep 24, 2021
Merge #70636
4485c87 
70636: tabledesc: validate that old FK representation is not used r=postamar a=postamar

Previously, pre-19.2, we used to use a different foreign key
representation. We have since then migrated off of it. This commit adds
validation checks to verify that we are no longer using it.

This commit also makes superficial changes to the
catalog.TableDescriptor interface.

Fixes #66262

Release note: None

Co-authored-by: Marius Posta <marius@cockroachlabs.com>
@craig craig bot closed this as completed in de5c7b5 Sep 24, 2021
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tabledesc: validate that old FK representation is not used postamar/cockroach
3 participants
@jlinder @ajwerner @postamar