tabledesc: validate that old FK representation is not used

Previously, pre-19.2, we used to use a different foreign key
representation. We have since then migrated off of it. This commit adds
validation checks to verify that we are no longer using it.

This commit also makes superficial changes to the
catalog.TableDescriptor interface.

Fixes cockroachdb#66262

Release note: None

pkg/BUILD.bazel

@@ -180,7 +180,6 @@ ALL_TESTS = [
     "//pkg/spanconfig/spanconfigkvaccessor:spanconfigkvaccessor_test",
     "//pkg/spanconfig/spanconfigmanager:spanconfigmanager_test",
     "//pkg/sql/catalog/catalogkeys:catalogkeys_test",
-    "//pkg/sql/catalog/catalogkv:catalogkv_test",
     "//pkg/sql/catalog/catformat:catformat_test",
     "//pkg/sql/catalog/catprivilege:catprivilege_test",
     "//pkg/sql/catalog/colinfo:colinfo_test",

pkg/sql/catalog/catalogkv/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//build:STRINGER.bzl", "stringer")
 
 go_library(
@@ -33,27 +33,6 @@ go_library(
     ],
 )
 
-go_test(
-    name = "catalogkv_test",
-    size = "small",
-    srcs = ["unwrap_validation_test.go"],
-    data = glob(["testdata/**"]),
-    embed = [":catalogkv"],
-    deps = [
-        "//pkg/keys",
-        "//pkg/kv",
-        "//pkg/roachpb:with-mocks",
-        "//pkg/sql/catalog",
-        "//pkg/sql/catalog/descpb",
-        "//pkg/testutils",
-        "//pkg/util/encoding/csv",
-        "//pkg/util/hlc",
-        "//pkg/util/protoutil",
-        "@com_github_cockroachdb_errors//:errors",
-        "@com_github_stretchr_testify//require",
-    ],
-)
-
 stringer(
     name = "gen-descriptorkind-stringer",
     src = "catalogkv.go",

pkg/sql/catalog/descriptor.go

@@ -342,8 +342,6 @@ type TableDescriptor interface {
 	ForeachInboundFK(f func(fk *descpb.ForeignKeyConstraint) error) error
 	GetConstraintInfo() (map[string]descpb.ConstraintDetail, error)
 	AllActiveAndInactiveForeignKeys() []*descpb.ForeignKeyConstraint
-	GetInboundFKs() []descpb.ForeignKeyConstraint
-	GetOutboundFKs() []descpb.ForeignKeyConstraint
 
 	GetLocalityConfig() *descpb.TableDescriptor_LocalityConfig
 	IsLocalityRegionalByRow() bool

pkg/sql/catalog/tabledesc/structured.go

@@ -33,6 +33,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/types"
 	"github.com/cockroachdb/cockroach/pkg/util/errorutil/unimplemented"
 	"github.com/cockroachdb/cockroach/pkg/util/hlc"
+	"github.com/cockroachdb/cockroach/pkg/util/iterutil"
 	"github.com/cockroachdb/cockroach/pkg/util/protoutil"
 	"github.com/cockroachdb/errors"
 	"github.com/lib/pq/oid"
@@ -314,6 +315,9 @@ func (desc *wrapper) ForeachDependedOnBy(
 ) error {
 	for i := range desc.DependedOnBy {
 		if err := f(&desc.DependedOnBy[i]); err != nil {
+			if iterutil.Done(err) {
+				return nil
+			}
 			return err
 		}
 	}
@@ -327,6 +331,9 @@ func (desc *wrapper) ForeachOutboundFK(
 ) error {
 	for i := range desc.OutboundFKs {
 		if err := f(&desc.OutboundFKs[i]); err != nil {
+			if iterutil.Done(err) {
+				return nil
+			}
 			return err
 		}
 	}
@@ -338,6 +345,9 @@ func (desc *wrapper) ForeachOutboundFK(
 func (desc *wrapper) ForeachInboundFK(f func(fk *descpb.ForeignKeyConstraint) error) error {
 	for i := range desc.InboundFKs {
 		if err := f(&desc.InboundFKs[i]); err != nil {
+			if iterutil.Done(err) {
+				return nil
+			}
 			return err
 		}
 	}
@@ -354,6 +364,9 @@ func (desc *wrapper) NumFamilies() int {
 func (desc *wrapper) ForeachFamily(f func(family *descpb.ColumnFamilyDescriptor) error) error {
 	for i := range desc.Families {
 		if err := f(&desc.Families[i]); err != nil {
+			if iterutil.Done(err) {
+				return nil
+			}
 			return err
 		}
 	}