Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate zfs roachtest failures #68716

Closed
bananabrick opened this issue Aug 11, 2021 · 0 comments · Fixed by #106858
Closed

Investigate zfs roachtest failures #68716

bananabrick opened this issue Aug 11, 2021 · 0 comments · Fixed by #106858
Assignees
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. skipped-test T-storage Storage Team

Comments

@bananabrick
Copy link
Contributor

bananabrick commented Aug 11, 2021

We're seeing the zfs clearrange roachtest fail sporadically when the import workload is run. Investigate why the failures happen.

Failures:
#68420
#68303
#69194
#69193

Jira issue: CRDB-9199

@bananabrick bananabrick added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 11, 2021
@bananabrick bananabrick self-assigned this Aug 11, 2021
@bananabrick bananabrick changed the title Investigate zfs roachtests failures Investigate zfs roachtest failures Aug 11, 2021
@blathers-crl blathers-crl bot added the T-storage Storage Team label Sep 10, 2021
@jbowens jbowens added the A-storage Relating to our storage engine (Pebble) on-disk storage. label Sep 10, 2021
@nicktrav nicktrav added the branch-master Failures and bugs on the master branch. label Jul 7, 2023
@itsbilal itsbilal self-assigned this Jul 13, 2023
itsbilal added a commit to itsbilal/cockroach that referenced this issue Jul 14, 2023
In my test runs, the clearrange/zfs tests reliably pass
now, thanks to improvements over the 1.5+ years since
this test was first skipped. This change unskips the
checks=true/rangeTs=true variant of the test to get
the highest possible test coverage while not significantly
blowing up the list of tests (as rangeTs=false is less supported
going forward anyway).

Epic: none
Fixes cockroachdb#68716.
Fixes cockroachdb#74708.

Release note: None
craig bot pushed a commit that referenced this issue Jul 17, 2023
106858: cmd/roachtest: Unskip clearrange/zfs test r=RaduBerinde a=itsbilal

In my test runs, the clearrange/zfs tests reliably pass now, thanks to improvements over the 1.5+ years since this test was first skipped. This change unskips the checks=true/rangeTs=true variant of the test to get the highest possible test coverage while not significantly blowing up the list of tests (as rangeTs=false is less supported going forward anyway).

Epic: none
Fixes #68716.
Fixes #74708.

Release note: None

Co-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>
@craig craig bot closed this as completed in 9f7465d Jul 17, 2023
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. skipped-test T-storage Storage Team
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants