cmd/roachtest: Unskip clearrange/zfs test #106858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsbilal
requested review from
smg260,
renatolabs,
jbowens and
a team
and removed request for
a team
|
This change is |
RaduBerinde
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Nice!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jbowens, @renatolabs, and @smg260)
jbowens
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
itsbilal
force-pushed
the
unskip-clearrange-zfs
branch
from
4ec4914
to
c9a23f2
Compare
|
TFTRs! bors r=RaduBerinde |
In my test runs, the clearrange/zfs tests reliably pass now, thanks to improvements over the 1.5+ years since this test was first skipped. This change unskips the checks=true/rangeTs=true variant of the test to get the highest possible test coverage while not significantly blowing up the list of tests (as rangeTs=false is less supported going forward anyway). Epic: none Fixes cockroachdb#68716. Fixes cockroachdb#74708. Release note: None
itsbilal
force-pushed
the
unskip-clearrange-zfs
branch
from
c9a23f2
to
9f7465d
Compare
|
Canceled. |
|
bors r=RaduBerinde |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my test runs, the clearrange/zfs tests reliably pass now, thanks to improvements over the 1.5+ years since this test was first skipped. This change unskips the checks=true/rangeTs=true variant of the test to get the highest possible test coverage while not significantly blowing up the list of tests (as rangeTs=false is less supported going forward anyway).
Epic: none
Fixes #68716.
Fixes #74708.
Release note: None