dev: dev doctor should initialize submodules for you if necessary
#72247
Assignees
Labels
A-build-system
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-dev-inf
Comments
rickystewart
added
C-enhancement
craig bot
pushed a commit
that referenced
this issue
Feb 2, 2022
…75871 58261: opt,sql: use paired-joins with non-covering indexes for left joins r=rytaft a=sumeerbhola This is done when the left outer/semi/anti join can use a lookup join. Prior to this, when the non-covering index could not fully evaluate the filter for left join we could not generate a lookup join. With this change: - Left outer join becomes a pair of two left outer joins. - Left semi join is a pair of inner join followed by left semi join. - Left anti join is a pair of left outer join followed by left anti join. Informs #55452 Release note (performance improvement): The optimizer can now generate lookup joins in certain cases for non-covering indexes, when performing a left outer/semi/anti join. 75746: dev: initialize submodules in `dev doctor` r=aayushshah15 a=aayushshah15 This commit adds a check to `dev doctor` to initialize submodules, like we do in our `Makefile`. Fixes #72247 Release note: None 75766: server: do not check decommission list for the tenant r=JeffSwenson a=JeffSwenson Previously, the system tenant would return PermissionDenied if the tenant's instance_id was equivalent to a decommissioned node's id. Now, the system tenant does not check the decommissioned node list if the incoming node_id belongs to a non-system tenant. This PR feeds the request context down to the OnOutgoingPing and OnIncomingPing callbacks. Previously the callbacks were using the ambient context. The only use of the context was a storage.MVCCGet call in nodeTombstoneStorage.IsDecommissioned. Release note: None 75804: sql: support RESET ALL statement r=otan a=rafiss fixes #75435 Release note (sql change): Support for the RESET ALL statement was added. This statement resets the values of all session variables to their default values. 75822: sql: error when setting timezone outside of postgres max utc offsets r=otan a=RichardJCai Release note (sql change): Previously, users would be able to set a UTC timezone offset of greater than 167 or less than -167. This now returns an error. Example: SET TIME ZONE '168' Gives error: invalid value for parameter "timezone": "'168'": cannot find time zone "168": UTC timezone offset is out of range. SET TIME ZONE '-168' Gives error: invalid value for parameter "timezone": "'-168'": cannot find time zone "-168": UTC timezone offset is out of range. Fixes #75168 Note: If a user has already set a UTC timezone offset outside of these bounds, it will be unchanged. 75843: c-deps/krb5: fix build for more recent versions of autoconf r=otan a=nicktrav More recent versions of `autoconf`, when used to build `krb5`, generates shell scripts with invalid syntax. Fix by pulling in the [upstream patch][1] for the issue into our tree. Closes #72529. [1]: krb5/krb5@f78edbe 75845: vendor: bump Pebble to 38b68e17aa97 r=jbowens a=nicktrav Pebble commits: ``` 38b68e17 internal/batchskl: return error on index overflow 8440f290 internal/manifest: use a line sweep to optimize NewL0Sublevels 0f5acb26 sstable: add direct block reading to suffix rewriter 26856d10 db: avoid stats flake in TestMemTableReservation b452808f sstable: Make sstable Writer.Close idempotent 17fe1a65 sstable: add RewriteKeySuffixes function c9e6edfc db: expose metrics on count and earliest seqnum of snapshots b958d9a7 sstable: add a writeQueue to the sstable writer c8dad06c db: disable automatic compactions in `MetricsTest` 015f5e38 internal/rangekey: fix range key iteration bug ``` The commit `38b68e17` contains the fix for #69906. Closes #69906. Release note: none 75857: sql: fix small race in distIndexBackfiller r=adityamaru a=stevendanna This fixes a small race condition in distIndexBackfiller. updateJobDetails calls SetResumeSpansInJob which mutates the ResumeSpanList in the job details. Normally, this is only called from the periodic updater. However, when the testing knob AlwasyUpdateIndexBackfillDetails is set, we also update it on every ProducerMetadata message we get back Release note: None 75865: build: address util.log.logcrash package rename r=knz a=rail After `util.log` was renamed to `util.log.logcrash`, the build system stopped updating the Sentry environment variable properly. Instead of setting it to the release version, it was falling back to the default "development" value. As a result, all Sentry reports went to the development environment bucket. This patch addresses the name change. Release note: None 75871: logictestccl: fix stale issue number in TODO r=arulajmani a=arulajmani We closed #69265 in favour of #70558, and the only remaining work left to address locality aware planning for tenants is captured in #75864. Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: Aayush Shah <aayush.shah15@gmail.com> Co-authored-by: Jeff <swenson@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: richardjcai <caioftherichard@gmail.com> Co-authored-by: Nick Travers <travers@cockroachlabs.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Rail Aliiev <rail@iqchoice.com> Co-authored-by: arulajmani <arulajmani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implement this logic in
dev doctor.Epic CRDB-8036
The text was updated successfully, but these errors were encountered: