dev: initialize submodules in dev doctor
#75746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aayushshah15
force-pushed
the
20220124_initSubmodulesDevDoctor
branch
from
ed05c22
to
c88409c
Compare
rickystewart
approved these changes
Feb 2, 2022
pkg/cmd/dev/doctor.go
Outdated
| if _, err = d.exec.CommandContextSilent(ctx, "git", "submodule", "update", "--init", "--recursive"); err != nil { | ||
| return err | ||
| } | ||
| if _, err = d.exec.CommandContextSilent(ctx, "mkdir", "-p", binDir); err != nil { |
There was a problem hiding this comment.
Nit: You can use d.os.MkdirAll(binDir) instead of shelling out to mkdir.
pkg/cmd/dev/doctor.go
Outdated
| if _, err = d.exec.CommandContextSilent(ctx, "mkdir", "-p", binDir); err != nil { | ||
| return err | ||
| } | ||
| if _, err = d.exec.CommandContextSilent(ctx, "touch", submodulesMarkerPath); err != nil { |
There was a problem hiding this comment.
Nit: You can use d.os.writeFile(submodulesMarkerPath, "") instead of shelling out.
This commit adds a check to `dev doctor` to initialize submodules, like we do in our `Makefile`. Release note: None
aayushshah15
force-pushed
the
20220124_initSubmodulesDevDoctor
branch
from
c88409c
to
8504245
Compare
|
TFTR bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check to
dev doctorto initialize submodules, like we doin our
Makefile.Fixes #72247
Release note: None