bazel: bump+mirror latest rules_go dependency
#77037
Assignees
Labels
A-build-system
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-dev-inf
Comments
irfansharif
added
C-enhancement
irfansharif
changed the title
rules_go dependencyrules_go dependency
craig bot
pushed a commit
that referenced
this issue
Feb 25, 2022
…77019 #77045 #77047 #77049 72925: sql, cli: support basic auto complete for sql keywords r=rafiss a=RichardJCai sql: add SHOW COMPLETIONS AT offset FOR syntax Release note (sql change): Support SHOW COMPLETIONS AT OFFSET <offset> FOR <stmt> syntax that returns a set of SQL keywords that can complete the keyword at <offset> in the given <stmt>. If the offset is in the middle of a word, then it returns the full word. For example SHOW COMPLETIONS AT OFFSET 1 FOR "SELECT" returns select. cli: support autocomplete Release note (cli change): CLI now auto completes on tab by using `SHOW COMPLETIONS AT OFFSET`. 76539: cli: Enable profiles and other debug info for tenants r=rimadeodhar a=rimadeodhar This PR updates debug.zip functionality to collect goroutine stacks and profiles for all active SQL instances for a tenant. This PR also addresses a bug where the nodes.json and status.json data was not getting populated correctly due to the switch to the `NodesList` API. This bug has been addressed by using the p;d `Nodes` API when the debug zip command is run against a storage server. Release note: None 76676: telemetry,sql: remove redaction from operational sql data r=abarganier a=dhartunian Previously, when redaction was introduced into CRDB, all unidentifiable strings were marked as redacted since that was the safer approach. We expected to later return with a closer look and differentiate more carefully between what should be redacted and what shouldn't. SQL names have been identified as operational-sensitive data that should not be redacted since it provides very useful debugging information and, while user-controlled, do not typically contain user-data since those would be stored in a Datum. This commit marks names as safe from redaction for telemetry logging in cases where the `sql.telemetry.query_sampling.enabled` cluster setting is enabled. Additionally, some log tags such as client IP addresses are not to be considered sensitive and are critical to debugging operational issues. They have also been marked as safe. In order to help with documenting these cases, a helper `SafeOperational()` has been added to the `log` package. This helps us mark strings as safe while documenting *why* we're doing so. Resolves #76595 Release note (security update, ops change): When the `sql.telemetry.query_sampling.enabled` cluster setting is enabled, SQL names and client IPs are no longer redacted in telemetry logs. 76754: physicalplan: add support for multi-stage execution of corr, covar_samp, sqrdiff, and regr_count aggregate functions. r=yuzefovich a=mneverov Fixes: #58347. Release note (performance improvement): corr, covar_samp, sqrdiff, and regr_count aggregate functions are now evaluated more efficiently in a distributed setting 76908: roachtest: update 22.1 version map to v21.2.6 r=bananabrick a=bananabrick Release note: None 76948: spanconfigreconciler{ccl}: apply system span config diffs to the store r=arulajmani a=adityamaru This change teaches the reconciler about system span configs. Concretely, we make the following changes: - A full reconciliation when checking for existing span configurations now asks for SpanConfigs corresponding to the SystemTargets relevant to the tenant. For the host tenant this includes the SystemTarget for the `entire-keyspace` as well as the SystemTarget for span configs installed by the host tenant on its tenant keyspace, and on other secondary tenant keyspaces. For secondary tenants this only includes the SystemTarget for span configs installed by it on its own tenant keyspace. - During incremental reconciliation, before applying our updates to the Store, we now also check for "missing protected timestamp system targets". These correspond to protected timestamp records that target a `Cluster` or a `Tenant` but no longer exist in the system.protected_ts_records table as they have been released by the client. For every such unique missing system target we apply a spanconfig.Deletion to the Store. In order to make the above possible, this change moves the ptsStateReader from the `spanconfigsqltranslator` package, to the top level `spanconfig` package. Informs: #73727 Release note: None 76990: sql, geo: Fix upper case geohash parsing and allow NULL arguments r=otan a=RichardJCai Release note (sql change): ST_Box2DFromGeoHash now accepts NULL arguments, the precision being NULL is the same as no precision being passed in at all. Upper case characters are now parsed as lower case characters for geohash, this matches Postgis behaviour. Resolves #75537 77006: changefeedccl: Fix data race in a test. r=miretskiy a=miretskiy Fix data race in TestChangefeedSendError. Release Notes: None 77014: log: Set content type header for http sink r=dhartunian a=rimadeodhar The content type header for the output of HTTP log sink is always set to text/plain irrespective of the log format. If the log format is JSON, we should set the content type to be application/json. Release note (bug fix): The content type header for the HTTP log sink is set to application/json if the format of the log output is JSON. 77019: sql: update tpcc and tpch stats r=rharding6373 a=rharding6373 This change rewrites the stats for tpcc and tpch to include the new table statistic avg_size. Fixes: #72332 Release note: None 77045: bazel: bump `rules_go` to pick up cockroachdb/rules_go#4 r=irfansharif a=rickystewart Closes #77037. Release note: None 77047: dev: make sure we inherit `stdout` and `stderr` when appropriate r=postamar,irfansharif a=rickystewart Otherwise `bazel build`/`test` output will be ugly (won't be colored/ use `ncurses`/etc.) Release note: None 77049: sql: skip flaky schema_changer/drop_database_cascade test r=postamar a=RichardJCai Release note: None Co-authored-by: richardjcai <caioftherichard@gmail.com> Co-authored-by: rimadeodhar <rima@cockroachlabs.com> Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Max Neverov <neverov.max@gmail.com> Co-authored-by: Arjun Nair <nair@cockroachlabs.com> Co-authored-by: Aditya Maru <adityamaru@gmail.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com> Co-authored-by: rharding6373 <harding@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
RajivTS
pushed a commit
to RajivTS/cockroach
that referenced
this issue
Mar 6, 2022
Closes cockroachdb#77037. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Need to pick up cockroachdb/rules_go#4. It'll help resolve #56178.
Epic CRDB-8036
The text was updated successfully, but these errors were encountered: