Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: roachmart/partition=true failed #81435

Closed
cockroach-teamcity opened this issue May 18, 2022 · 3 comments · Fixed by #81481
Closed

roachtest: roachmart/partition=true failed #81435

cockroach-teamcity opened this issue May 18, 2022 · 3 comments · Fixed by #81481
Assignees
@tbg
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 18, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.roachmart/partition=true failed with artifacts on master @ a35b848edb3f5562199b0f56bc27a6c576073d5d:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/roachmart/partition=true/run_1
	roachmart.go:50,roachmart.go:54,roachmart.go:78,test_runner.go:876: output in run_121620.090087738_n1_workload_init_roachmart: ./workload init roachmart --local-zone=us-central1-b --local-percent=90 --users=10 --orders=100 --partition=true returned: COMMAND_PROBLEM: exit status 1
		(1) attached stack trace
		  -- stack trace:
		  | main.(*clusterImpl).RunE
		  | 	main/pkg/cmd/roachtest/cluster.go:1970
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerRoachmart.func1.1
		  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/roachmart.go:49
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerRoachmart.func1
		  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/roachmart.go:54
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerRoachmart.func2
		  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/roachmart.go:78
		  | main.(*testRunner).runTest.func2
		  | 	main/pkg/cmd/roachtest/test_runner.go:876
		  | runtime.goexit
		  | 	GOROOT/src/runtime/asm_amd64.s:1581
		Wraps: (2) output in run_121620.090087738_n1_workload_init_roachmart
		Wraps: (3) ./workload init roachmart --local-zone=us-central1-b --local-percent=90 --users=10 --orders=100 --partition=true returned
		  | stderr:
		  | I220518 12:16:21.364036 1 ccl/workloadccl/fixture.go:318  [-] 1  starting import of 2 tables
		  | Error: importing fixture: importing table users: pq: unknown generator: roachmart
		  |
		  | stdout:
		Wraps: (4) COMMAND_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload init roachmart --local-zone=us-central1-b --local-percent=90 --users=10 --orders=100 --partition=true
		  | ``````
		Wraps: (6) exit status 1
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.Cmd (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-15186
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels May 18, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label May 18, 2022
@tbg
Copy link
Member

tbg commented May 18, 2022

These are gonna be on me.

@tbg
Copy link
Member

tbg commented May 18, 2022

Probably #80226

@tbg tbg self-assigned this May 18, 2022
@tbg tbg mentioned this issue May 18, 2022
Merged
craig bot pushed a commit that referenced this issue May 19, 2022
@tbg
Merge #81481
c94d25e 
81481: workload:  default to fixtures only for pub-facing workloads r=otan a=tbg

For internal workloads fixtures won't load because the CRDB cluster
won't know about the workload.

Fixes #81422.
Fixes #81433.
Fixes #81434.
Fixes #81435.

Release note: None


Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
@cockroach-teamcity
Copy link
Member Author

roachtest.roachmart/partition=true failed with artifacts on master @ ce66acdbba801de88f1dd645eaedeb3834f23dbd:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/roachmart/partition=true/run_1
	roachmart.go:50,roachmart.go:54,roachmart.go:78,test_runner.go:876: output in run_120359.637559988_n1_workload_init_roachmart: ./workload init roachmart --local-zone=us-central1-b --local-percent=90 --users=10 --orders=100 --partition=true returned: COMMAND_PROBLEM: exit status 1
		(1) attached stack trace
		  -- stack trace:
		  | main.(*clusterImpl).RunE
		  | 	main/pkg/cmd/roachtest/cluster.go:1970
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerRoachmart.func1.1
		  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/roachmart.go:49
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerRoachmart.func1
		  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/roachmart.go:54
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerRoachmart.func2
		  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/roachmart.go:78
		  | main.(*testRunner).runTest.func2
		  | 	main/pkg/cmd/roachtest/test_runner.go:876
		  | runtime.goexit
		  | 	GOROOT/src/runtime/asm_amd64.s:1581
		Wraps: (2) output in run_120359.637559988_n1_workload_init_roachmart
		Wraps: (3) ./workload init roachmart --local-zone=us-central1-b --local-percent=90 --users=10 --orders=100 --partition=true returned
		  | stderr:
		  | I220519 12:04:00.816811 1 ccl/workloadccl/fixture.go:318  [-] 1  starting import of 2 tables
		  | Error: importing fixture: importing table orders: pq: unknown generator: roachmart
		  |
		  | stdout:
		Wraps: (4) COMMAND_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload init roachmart --local-zone=us-central1-b --local-percent=90 --users=10 --orders=100 --partition=true
		  | ``````
		Wraps: (6) exit status 1
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.Cmd (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue May 19, 2022
@rafiss @koorosh
@tbg @fqazi @ChinemeremChigbo
Merge #81382 #81438 #81481 #81528 #81530
4584014 
81382: sql: fix database resolution for GRANT ALL TABLES r=otan a=rafiss

fixes #81002

Release note (bug fix): Fixed a bug where GRANT ALL TABLES IN SCHEMA
would not resolve the correct database name if it was explicitly
specified.

81438: ui: Plot circuit breaker tripped events as a rate values r=tbg a=koorosh

Resolves #78939

Before, Circuit Breaker Tripped events chart displayed the accumulated number
of events since the process started.

Now, it displays the number of events per aggregated interval of time.

Release note (ui change): Circuit Breaker Tripped events chart displays
rate of events per interval instead of the accumulated number of events.

<img width="988" alt="Screen Shot 2022-05-18 at 16 03 22" src="https://user-images.githubusercontent.com/3106437/169045058-b0424e72-08ef-4ceb-a1d1-f0f094048bd1.png">


81481: workload:  default to fixtures only for pub-facing workloads r=otan a=tbg

For internal workloads fixtures won't load because the CRDB cluster
won't know about the workload.

Fixes #81422.
Fixes #81433.
Fixes #81434.
Fixes #81435.

Release note: None


81528: sql: add logic test config for legacy schema changer r=fqazi a=fqazi

Fixes: #81454

Previously, when we enabled the declarative schema changer
by default we implicitly eliminated test coverage for the
legacy schema changer. This was inadequate because we run
the risk of now introducing regressions inside the legacy
code which can still be exercised in scenarios like explicit
transactions. To address this, this patch adds back a config
inside logictest for covering the legacy schema changer.

Release note: None

81530: ui: Incorrect link on CC SQL activity page r=lassenordahl a=ChinemeremChigbo

Before, in SQL Activity -> Transactions: when empty, the "Learn more about statements" link sends one to the transactions page

Now, the text has been changed to "Learn more about transactions"

Fixes: #78379

Release note (ui change): The "Learn more" link on an empty transactions link now mentions transactions.

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>
@craig craig bot closed this as completed in 682b303 May 19, 2022
@craig craig bot closed this as completed in #81481 May 19, 2022
andrewbaptist pushed a commit to andrewbaptist/cockroach that referenced this issue May 25, 2022
@tbg @andrewbaptist
workload: default to fixtures only for pub-facing workloads
8471e4e 
For internal workloads fixtures won't load because the CRDB cluster
won't know about the workload.

Fixes cockroachdb#81422.
Fixes cockroachdb#81433.
Fixes cockroachdb#81434.
Fixes cockroachdb#81435.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload: default to fixtures only for pub-facing workloads tbg/cockroach
3 participants
@jlinder @tbg @cockroach-teamcity