workload: default to fixtures only for pub-facing workloads #81481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
unknown-generator-fix
branch
from
5969cd3 to
1eede2a
Compare
otan
approved these changes
May 18, 2022
For internal workloads fixtures won't load because the CRDB cluster won't know about the workload. Fixes cockroachdb#81422. Fixes cockroachdb#81433. Fixes cockroachdb#81434. Fixes cockroachdb#81435. Release note: None
tbg
force-pushed
the
unknown-generator-fix
branch
from
1eede2a to
682b303
Compare
|
bors r=otan |
craig bot
pushed a commit
that referenced
this pull request
May 19, 2022
81481: workload: default to fixtures only for pub-facing workloads r=otan a=tbg For internal workloads fixtures won't load because the CRDB cluster won't know about the workload. Fixes #81422. Fixes #81433. Fixes #81434. Fixes #81435. Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
|
bors r- Actually let me wait until these tests have posted their nightly failures so I don't have to close extra issues |
|
Canceled. |
|
bors r=otan |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal workloads fixtures won't load because the CRDB cluster
won't know about the workload.
Fixes #81422.
Fixes #81433.
Fixes #81434.
Fixes #81435.
Release note: None